Address deprecation lints #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RavenNumber of Findings: 0 |
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
=======================================
Coverage 94.86% 94.86%
=======================================
Files 31 31
Lines 1536 1536
=======================================
Hits 1457 1457
Misses 79 79 |
|
Can you also bump the over_react_test dep to 1.0.1 in this PR too? |
|
@jacehensley-wf I did. |
|
🤦♂️ I didn't see that |
|
+1 |
test/wsd_test_util/zone.dart
Outdated
| @@ -37,11 +37,15 @@ void storeZone([Zone zone]) { | |||
| /// Calls [expect] in package:test/test.dart in the zone stored in [setZone]. | |||
| /// | |||
| /// Useful for expectations in blocks called in other zones. | |||
| void zonedExpect(actual, matcher, | |||
| {String reason, bool verbose: false, ErrorFormatter formatter}) { | |||
| void zonedExpect(actual, matcher, { | |||
There was a problem hiding this comment.
This is not part of the public API, these can just be removed now.
aaronlademann-wf
force-pushed
the
address-deprecations
branch
from
ba42767 to
1690860
Compare
|
@jacehensley-wf feedback addressed. |
|
+1 |
|
QA +10
Ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimate problem:
The
dart-lang/testhas a number of deprecations that we couldn't address previously because of some issues with thethrowsAreplacement. Those issues appear to have been fixed in a recent update to the test package.How it was fixed:
Address deprecations
Testing suggestions:
Passing CI build
Areas of regression
Tests
FYA: @greglittlefield-wf @jacehensley-wf @clairesarsam-wf