Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FED-3114: Lazy #941

Merged
merged 33 commits into from
Oct 7, 2024
Merged

FED-3114: Lazy #941

merged 33 commits into from
Oct 7, 2024

Conversation

kealjones-wk
Copy link
Contributor

@kealjones-wk kealjones-wk commented Sep 10, 2024 •
edited
Loading

Depends on Workiva/react-dart#406

Motivation

We need React.lazy in order to support some new asynchronous component patterns.

Changes

  • Add React.lazy
  • Add a lot of test coverage

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed
    • Steps from PR author:
      • Run the suspense example and ensure it is working correctly still
      • CI Passes
    • Anything falling under manual testing criteria outlined in CONTRIBUTING.md

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Frontend Frameworks Design member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@kealjones-wk kealjones-wk marked this pull request as ready for review September 16, 2024 21:19
kealjones-wk
kealjones-wk commented Sep 16, 2024
View reviewed changes
test/over_react/component/suspense_component_test.dart
factoryConfig,
);
}

const lazyId = 'lazy';
const gregIsNotLazy = 'gregisnotlazy';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@kealjones-wk kealjones-wk mentioned this pull request Sep 16, 2024
Merged
@kealjones-wk kealjones-wk added the Hold Hold merges label Sep 17, 2024
greglittlefield-wf
greglittlefield-wf requested changes Sep 28, 2024
View reviewed changes
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly some comments on tests, otherwise this is looking good!

lib/src/util/lazy.dart Outdated Show resolved Hide resolved
test/over_react/component/lazy_test.dart Outdated Show resolved Hide resolved
test/over_react/component/lazy_test.dart Outdated Show resolved Hide resolved
test/over_react/component/lazy_test.dart Outdated Show resolved Hide resolved
test/over_react/component/lazy_test.dart Show resolved Hide resolved
test/over_react/component/lazy_test.dart Outdated Show resolved Hide resolved
test/over_react/component/lazy_test.dart Outdated Show resolved Hide resolved
lib/src/util/lazy.dart Outdated Show resolved Hide resolved
greglittlefield-wf
greglittlefield-wf requested changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more things, should be my final pass!

test/over_react/component/lazy_test.dart Outdated Show resolved Hide resolved
test/over_react/component/lazy_test.dart Show resolved Hide resolved
lib/src/util/lazy.dart Show resolved Hide resolved
test/over_react/component/lazy_test.dart Outdated Show resolved Hide resolved
greglittlefield-wf
greglittlefield-wf requested changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last round of feedback on tests

test/over_react/component/lazy_test.dart Outdated Show resolved Hide resolved
greglittlefield-wf
greglittlefield-wf reviewed Oct 7, 2024
View reviewed changes
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just need to get the react-dart changes released

greglittlefield-wf
greglittlefield-wf approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10 pending passing CI

@greglittlefield-wf greglittlefield-wf removed the Hold Hold merges label Oct 7, 2024
@greglittlefield-wf
Copy link
Contributor

@Workiva/release-management-p

rmconsole-wf
rmconsole-wf approved these changes Oct 7, 2024
View reviewed changes
Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole7-wk rmconsole7-wk merged commit c7db23b into master Oct 7, 2024
7 checks passed
@rmconsole7-wk rmconsole7-wk deleted the FED-3114-lazy branch October 7, 2024 21:54
@rmconsole-readonly-wk rmconsole-readonly-wk mentioned this pull request Oct 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greglittlefield-wf greglittlefield-wf greglittlefield-wf approved these changes

@rmconsole-wf rmconsole-wf rmconsole-wf approved these changes

Assignees
No one assigned
Labels
Merge Requirements Met RM Ready semver: Minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kealjones-wk @aviary2-wf @greglittlefield-wf @rmconsole-wf @rmconsole7-wk