FED-2994 Update class component defaults codemod to take public-ness into account

[sydneyjodon-wk]

Motivation

Right now, the class component codemod always makes defaulted props required, but that goes against our guidance (see here) in cases where those props are public.

This codemod should only make those props required when classes are private.

Changes

• Move class defaulted props codemod into prop requiredness codemod to use public api info to only make defaulted props required if they are not public

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

• Tests were updated and provide good coverage of the changeset and other affected code
• Manual testing was performed if needed
  • Steps from PR author:
    • CI passes
    • Good test coverage
  • Anything falling under manual testing criteria outlined in CONTRIBUTING.md

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

• A Frontend Frameworks Design member has reviewed these changes
• There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
• For release PRs - Version metadata in Rosie comment is correct

[aviary2-wf]

Security Insights

No security relevant content was detected by automated scans.

Action Items

• Review PR for security impact; comment "security review required" if needed or unsure
• Verify aviary.yaml coverage of security relevant code

---

Questions or Comments? Reach out on Slack: #support-infosec.

[greglittlefield-wf]

Just two comments!

[greglittlefield-wf]

Does this not work when added to the sequence below, like so?

     exitCode = await runInteractiveCodemodSequence(
       dartPaths,
       [
+        ClassComponentRequiredDefaultPropsMigrator(null, recommender),
         RequiredPropsSuggestor(
           recommender,
           trustRequiredAnnotations:
               parsedArgs[_Flags.trustRequiredAnnotations] as bool,
         ),
       ],
       defaultYes: true,
       args: codemodArgs,
       additionalHelpOutput: argParser.usage,
     );

Not a huge deal, but it would be nice if consumers who wanted to apply all patches via the prompt (like if they didn't think to pass --yes-to-all) didn't have to do so twice.

[sydneyjodon-wk]

It combines the patches when I put them together 😢

'mixin TestPrivatePropsMixin on UiProps {\n'
              '  String/*?*/ notDefaultedOptional;\n'
              '  /*late*/ String notDefaultedAlwaysSet;\n'
              '  /*late/*?*/*/ String/*?*/ defaultedN/*?*/ullable;\n'
              '  /*late*/ num/*!*/ defaultedNonNullable;\n'
              '}\n'

https://github.com/Workiva/over_react_codemod/actions/runs/11372701838/job/31637614201?pr=299

[greglittlefield-wf]

Hm okay, thanks for trying!

There's probably a bug in dart_codemod, then, possibly due to reusing FileContext/AnalysisContextCollection between suggestors.

[greglittlefield-wf]

+10

[greglittlefield-wf]

@Workiva/release-management-p

[rmconsole-wf]

+1 from RM