Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FED-3143 Null Safety Codemod for connect props #302

Merged
merged 12 commits into from
Oct 23, 2024

Conversation

sydneyjodon-wk
Copy link
Contributor

@sydneyjodon-wk sydneyjodon-wk commented Oct 23, 2024

This is based on #298 to share the new e2e tests

Closes #295

Motivation

Currently, after migrating connected components, required prop validation throws when consuming those components for any required props that are only set within mapStateToProps/mapActionsToProps/etc.

https://workiva.slack.com/archives/CEFTMBPAA/p1726516120035799
Workiva/over_react#942 (comment)
There are quite a few usages of connect (SourceGraph) that will be impacted as they migrate to null safety, so we should codemod them

Changes

  • Add codemod to add disabled prop validation annotations for connect usages

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed
    • Steps from PR author:
      • CI passes
      • Good test coverage
      • QA in another repo
    • Anything falling under manual testing criteria outlined in CONTRIBUTING.md

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Frontend Frameworks Design member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@sydneyjodon-wk sydneyjodon-wk changed the base branch from master to add-state-mixin-suggestor October 23, 2024 00:02
@aviary3-wk
Copy link

aviary3-wk commented Oct 23, 2024

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@sydneyjodon-wk sydneyjodon-wk changed the title FED-3143 Codemod for connect props FED-3143 Null Safety Codemod for connect props Oct 23, 2024
@sydneyjodon-wk sydneyjodon-wk marked this pull request as ready for review October 23, 2024 00:04
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, QAing now

Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole4-wk rmconsole4-wk merged commit 86c480a into master Oct 23, 2024
6 checks passed
@rmconsole4-wk rmconsole4-wk deleted the connect-required-props branch October 23, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add codemod for connect and null safety
7 participants