Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIP-2512 Add more utils from over_react #11

Merged
merged 14 commits into from
Jul 24, 2017
Merged

UIP-2512 Add more utils from over_react #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
493f731
Relax lints
aaronlademann-wf Jul 13, 2017
877ca00
Address outstanding lints
aaronlademann-wf Jul 13, 2017
81c0d81
Bump test concurrency
aaronlademann-wf Jul 13, 2017
f87edea
Expose over_react.ValidationUtil test utils
aaronlademann-wf Jul 13, 2017
7eb98cb
Expose common component tests
aaronlademann-wf Jul 13, 2017
c6d225b
Add string utils
aaronlademann-wf Jul 13, 2017
3b3841b
Add zone utils
aaronlademann-wf Jul 13, 2017
902be17
Expose js component util
aaronlademann-wf Jul 13, 2017
04c2452
Fix typo
aaronlademann-wf Jul 13, 2017
0bda78e
Add link to API docs
aaronlademann-wf Jul 13, 2017
8caf0dc
Remove unnecessary component for tests
aaronlademann-wf Jul 13, 2017
3c66e21
Revert "Add string utils"
aaronlademann-wf Jul 13, 2017
5df6ce3
Improve doc comment
aaronlademann-wf Jul 13, 2017
59bb9c2
Add tests for commonComponentTests
aaronlademann-wf Jul 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,9 @@ When coming up with test ID strings:

## Documentation

You would never skip reading the docs for a new language you are asked to learn, so _please_ don't skip over reading these, either.
You would never skip reading the docs for a new language you are asked to learn,
so _please_ don't skip over reading [our API documentation][api-docs] either.

+ In-depth Dart doc comments for components props and utilities are available, for use when browsing and autocompleting code in an IDE.

## Contributing

Expand All @@ -127,5 +127,6 @@ The `over_react_test` library adheres to [Semantic Versioning](http://semver.org



[api-docs]: https://www.dartdocs.org/documentation/over_react_test/1.0.0/over_react_test/over_react_test-library.html
[contributing-docs]: https://github.com/Workiva/over_react/blob/master/.github/CONTRIBUTING.md
[over-react]: https://github.com/Workiva/over_react
6 changes: 3 additions & 3 deletions analysis_options.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ linter:
- no_adjacent_strings_in_list
- no_duplicate_case_values
# - non_constant_identifier_names
- omit_local_variable_types
# - omit_local_variable_types
# - one_member_abstracts
- only_throw_errors
# - overridden_fields
Expand All @@ -46,10 +46,10 @@ linter:
- prefer_collection_literals
- prefer_const_constructors
- prefer_contains
- prefer_expression_function_bodies
# - prefer_expression_function_bodies
# - prefer_final_fields
# - prefer_final_locals
- prefer_function_declarations_over_variables
# - prefer_function_declarations_over_variables
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf Jul 13, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this lint disabled? Seems like it'd be valuable to keep enabled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To get rid of noisy lints that we have no intention of addressing.

If someone wants to address them, thats cool - but the analyzer view within the IDE is most useful when it is empty when you start your work.

- prefer_initializing_formals
- prefer_interpolation_to_compose_strings
- prefer_is_empty
Expand Down
6 changes: 5 additions & 1 deletion lib/over_react_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,12 @@
// See the License for the specific language governing permissions and
// limitations under the License.

export 'src/over_react_test/common_component_util.dart';
export 'src/over_react_test/custom_matchers.dart';
export 'src/over_react_test/dom_util.dart';
export 'src/over_react_test/jacket.dart';
export 'src/over_react_test/js_component.dart';
export 'src/over_react_test/react_util.dart';
export 'src/over_react_test/validation_util.dart';
export 'src/over_react_test/wrapper_component.dart';
export 'src/over_react_test/jacket.dart';
export 'src/over_react_test/zone_util.dart';
Loading