Null safety migration #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
greglittlefield-wf
requested changes
Jan 18, 2024
|
|
||
| /// Clears the list of [ValidationUtil.warn]ings that have been recorded since | ||
| /// [startRecordingValidationWarnings] was first called. | ||
| /// | ||
| /// > Related: [getValidationWarnings] | ||
| void clearValidationWarnings() { | ||
| _validationWarnings.clear(); | ||
| if (_validationWarnings == null) { | ||
| throw StateError('Need to call startRecordingValidationWarnings() first.'); |
There was a problem hiding this comment.
We love a helpful error message 😍
greglittlefield-wf
approved these changes
Jan 23, 2024
|
|
||
| setUpAll(() { | ||
| nodesBefore = document.body.children.toSet(); | ||
| nodesBefore = document.body!.children.toSet(); |
There was a problem hiding this comment.
i understand that sure a document might not have a body but given how often that is a case this feels ridiculous lol
kealjones-wk
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Migrate over_react_test to null safety.
Changes
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Consumer tests pass - ignore for now since over_react needs to be released so we will test them togetherhttps://github.com/Workiva/cerebral-ui/pull/6107https://github.com/Workiva/admin_client/pull/6099https://github.com/Workiva/xbrl-module/pull/5815https://github.com/Workiva/graph_app/pull/69830https://github.com/Workiva/wdesk_sdk/pull/12130https://github.com/Workiva/graph_ui/pull/7638Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: