-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIP-2411: Basic DDC Support #121
Conversation
// customComponent({'key': 'twoVariadicChildren2'}, customComponent({}), customComponent({})), | ||
// customComponent({'key': 'fiveVariadicChildren2'}, '', customComponent({}), '', customComponent({}), ''), | ||
]) | ||
, querySelector('#content')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to ensure there are no regressions in variadic children in the VM or dart2js, can we perform these validations in actual test files?
Actually, I have some commits where there are tests wired up for passing in children... lemme see if I can get those changes in a good state for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Factory tests are now up on this PR. Should I remove this example file? It was a bit useful in poking around ddc runtime errors would be trivial to re-create for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine leaving this example in
test('an empty List', () { | ||
var instance = factory({}, []); | ||
expect(getJsChildren(instance), equals([])); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add one more test that a single iterable child is converted to a list successfully? (A regression test for your fix in 3dce4a5)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in 664f842
+1 |
QA +10
|
Ultimate problem
Consumers need
react-dart
to be compilable with the ddc.Solution
How to +10/QA
pub run test -p chrome
pub run test -p content-shell
call_and_nosuchmethod_test.html
and an input related error inreact_test.html
.please review: @greglittlefield-wf @jacehensley-wf @aaronlademann-wf