UIP-2411: Basic DDC Support #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // customComponent({'key': 'twoVariadicChildren2'}, customComponent({}), customComponent({})), | ||
| // customComponent({'key': 'fiveVariadicChildren2'}, '', customComponent({}), '', customComponent({}), ''), | ||
| ]) | ||
| , querySelector('#content')); |
There was a problem hiding this comment.
In order to ensure there are no regressions in variadic children in the VM or dart2js, can we perform these validations in actual test files?
Actually, I have some commits where there are tests wired up for passing in children... lemme see if I can get those changes in a good state for this PR.
There was a problem hiding this comment.
Factory tests are now up on this PR. Should I remove this example file? It was a bit useful in poking around ddc runtime errors would be trivial to re-create for that.
There was a problem hiding this comment.
I'm fine leaving this example in
| test('an empty List', () { | ||
| var instance = factory({}, []); | ||
| expect(getJsChildren(instance), equals([])); | ||
| }); |
|
+1 |
|
QA +10
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimate problem
Consumers need
react-dartto be compilable with the ddc.Solution
How to +10/QA
pub run test -p chromepub run test -p content-shellcall_and_nosuchmethod_test.htmland an input related error inreact_test.html.please review: @greglittlefield-wf @jacehensley-wf @aaronlademann-wf