Skip to content

Conversation

aaronlademann-wf
Copy link
Collaborator

@aaronlademann-wf aaronlademann-wf commented Jan 13, 2021

Using Github actions for CI is cool, and Travis is dead.

@aviary3-wk
Copy link

Security Insights

(2) Vulnerable direct dependencies were detected
  • 1 vulns in ini < 1.3.6 via package-lock.json
  • 1 vulns in node-fetch < 2.6.1 via package-lock.json
  • Action Items


    Questions or Comments? Reach out on Slack: #support-infosec.

    @aaronlademann-wf aaronlademann-wf changed the title Add dart.yml for gh actions CI Set up Github actions CI Jan 13, 2021
    @semveraudit-wf
    Copy link

    semveraudit-wf commented Jan 13, 2021

    Public API Changes

    No changes to the public API found for commit 76147d6

    Showing results for 76147d6

    Powered by semver-audit-service. Please report any problems by filing an issue.
    Reported by the dart semver audit client 2.2.0
    Browse public API.

    Last edited UTC Jan 13 at 20:06:55

    @aaronlademann-wf aaronlademann-wf force-pushed the gh-actions-ci branch 7 times, most recently from e64a532 to cb1fd21 Compare January 13, 2021 18:42
    @aaronlademann-wf aaronlademann-wf force-pushed the gh-actions-ci branch 2 times, most recently from 14458ca to fc6a4fd Compare January 13, 2021 19:36
    @aaronlademann-wf aaronlademann-wf marked this pull request as ready for review January 13, 2021 19:37
    Copy link
    Collaborator

    @greglittlefield-wf greglittlefield-wf left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Just one comment

    Comment on lines +33 to +34
    # TODO: Uncomment this, and remove the Dart 2.7.2 format step in the Workiva Build Dockerfile
    # once we are able to bump the lower bound of SDK.
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    We don't need to keep formatting in Dart 2.7.2; before my Dockerfile PR, we had been formatting on stable (it doesn't matter to me tohugh)

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I think most contributors are running 2.7.x - so we should keep formatting that way IMO.

    Copy link
    Collaborator

    @joebingham-wk joebingham-wk left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This is dope! I'm excited to switch to actions. I just had one question!

    Copy link
    Collaborator

    @greglittlefield-wf greglittlefield-wf left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    +10

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    6 participants