-
Notifications
You must be signed in to change notification settings - Fork 67
Set up Github actions CI #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Security Insights(2) Vulnerable direct dependencies were detectedini < 1.3.6 via package-lock.json node-fetch < 2.6.1 via package-lock.json Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
5f3fa5b
to
d8135a0
Compare
Public API ChangesNo changes to the public API found for commit 76147d6 Showing results for 76147d6
Last edited UTC Jan 13 at 20:06:55 |
e64a532
to
cb1fd21
Compare
14458ca
to
fc6a4fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment
# TODO: Uncomment this, and remove the Dart 2.7.2 format step in the Workiva Build Dockerfile | ||
# once we are able to bump the lower bound of SDK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to keep formatting in Dart 2.7.2; before my Dockerfile PR, we had been formatting on stable (it doesn't matter to me tohugh)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think most contributors are running 2.7.x - so we should keep formatting that way IMO.
9e52bb3
to
76147d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is dope! I'm excited to switch to actions. I just had one question!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+10
Using Github actions for CI is cool, and Travis is dead.