Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Dart 2.13 #315

Merged
merged 9 commits into from
Aug 31, 2021
Merged

Conversation

sourcegraph-wk
Copy link

This PR updates the Dockerfile and skynet.yaml for each Dart repo to use
Dart 2.13 versions of the base docker images (at this point these will be
wip base images) to verify that full CI checks will pass when using Dart 2.13.


This PR was created automatically from a Sourcegraph batch change.
This PR is just a test and should not be merged
Please reach out to #support-client-plat with any questions.

Created by Sourcegraph batch change Workiva/dart_213_test.

@aviary-wf
Copy link

aviary-wf commented Jul 29, 2021

Security Insights

(6) Vulnerable direct dependencies were detected
  • 1 vulns in browserslist < 4.16.5 via yarn.lock
  • 1 vulns in elliptic < 6.5.4 via yarn.lock
  • 1 vulns in glob-parent < 5.1.2 via yarn.lock
  • 1 vulns in lodash < 4.17.21 via yarn.lock
  • 1 vulns in path-parse < 1.0.7 via yarn.lock
  • 1 vulns in ssri < 6.0.2 via yarn.lock
  • Action Items


    Questions or Comments? Reach out on Slack: #support-infosec.

    @semveraudit-wf
    Copy link

    semveraudit-wf commented Aug 11, 2021

    Public API Changes

    No changes to the public API found for commit 4b72b1f

    Showing results for 4b72b1f

    Powered by semver-audit-service. Please report any problems by filing an issue.
    Reported by the dart semver audit client 2.2.2
    Browse public API.

    Last edited UTC Aug 11 at 23:41:48

    @robbecker-wf robbecker-wf changed the title TEST: Run CI on Dart 2.13 Upgrade to Dart 2.13 Aug 29, 2021
    @robbecker-wf robbecker-wf added the Hold Hold merges label Aug 29, 2021
    @robbecker-wf robbecker-wf marked this pull request as ready for review August 29, 2021 19:58
    @@ -1,56 +1 @@
    FROM drydock-prod.workiva.net/workiva/dart_build_image:1
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    I don't think we can remove all of this - afaik, we at least need a stage that runs pub get so that workiva-build can scrape the pubspec.lock for auditing and dep tracking purposes

    js_src/dart_env_dev.js Outdated Show resolved Hide resolved
    @robbecker-wf robbecker-wf removed the Hold Hold merges label Aug 31, 2021
    Copy link

    @annawatson-wk annawatson-wk left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    QA +1, CI passes

    @robbecker-wf
    Copy link
    Member

    @Workiva/release-management-p

    @rmconsole2-wf rmconsole2-wf merged commit 56b7baa into master Aug 31, 2021
    Copy link

    @rmconsole-wf rmconsole-wf left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    +1 from RM

    @rmconsole2-wf rmconsole2-wf deleted the batch/client_platform/dart_213_test branch August 31, 2021 18:08
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.