-
Notifications
You must be signed in to change notification settings - Fork 67
FEDX-414 Add APIs and update deprecations in preparation for 7.0.0 release #372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a6c58c0
Update existing deprecations, notably outdated Component removal time…
greglittlefield-wf e9232c5
Add deprecations for additional APIs be removed in 7.0.0
greglittlefield-wf 0ee27d4
Fix deprecation message for non-public member
greglittlefield-wf fababf7
Backport useRefInit and htmlMain added in major version WIP
greglittlefield-wf 45aeae4
Deprecate constructors
greglittlefield-wf f973031
Add WIP 7.0.0 changelog entry
greglittlefield-wf a4a30a6
Reinstate deprecation for transferComponentState
greglittlefield-wf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty much guaranteed to break
Component
subclasses where lifecycle methods reference those fields, correct?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They'll be initialized for most lifecycle methods, except for "static" ones like
defaultProps
,getDerivedStateFromProps
, andgetDerivedStateFromError
where you shouldn't ever reference props/state.Besides those "static" lifecycle methods, they'll be initialized by the time we get to lifecycle methods.
The sequence during component mount is:
late
class fields are initializedprops
are initializedgetInitialState
orinitialState
is calledstate
is initializedcomponentWillMount
,componentDidMount
,render
, etc.) are calledFor example:
Basically, this shouldn't ever happen unless you're doing something wrong. And if you were doing it wrong, you'd probably get a null exception when trying to read off of them. I think I originally had a note to that effect in here, but scrapped it since I couldn't get wording I was happy with. I'll take a stab at re-adding it.