Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CP-2948 Add smithy.yaml #12

Merged
merged 3 commits into from
Nov 10, 2016
Merged

CP-2948 Add smithy.yaml #12

merged 3 commits into from
Nov 10, 2016

Conversation

jayudey-wf
Copy link
Contributor

Issue

  • We needed to add a smithy.yaml for release management to more easily track dependencies.

Changes

Source:

  • Included smithy.yaml

Tests:

  • n/a

Areas of Regression

  • passing CI's

Testing

  • passing CI

Code Review

@maxwellpeterson-wf
@evanweible-wf
@dustinlessard-wf
@sebastianmalysa-wf

@aviary-wf
Copy link

Raven

Number of Findings: 0

@rmconsole-wf rmconsole-wf changed the title Add smithy.yaml CP-2948 Add smithy.yaml Nov 10, 2016
@maxwellpeterson-wf
Copy link
Member

+1

@sebastianmalysa-wf
Copy link

+1

@charliekump-wf
Copy link
Contributor

+10 CI Passes

@charliekump-wf
Copy link
Contributor

Quality Review Approval: +1

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
  • Unit test created/updated - N/A
  • All unit tests pass

Merging into master.

@charliekump-wf charliekump-wf merged commit cdcd45a into master Nov 10, 2016
@charliekump-wf charliekump-wf deleted the smithy branch November 10, 2016 21:29
@bender-wk bender-wk mentioned this pull request Jun 21, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Merge Requirements Met
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jayudey-wf @aviary-wf @maxwellpeterson-wf @sebastianmalysa-wf @charliekump-wf @rmconsole-wf