Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-1145 Travis CI, sockjs-dart-client #8

Merged
merged 1 commit into from
Nov 25, 2015
Merged

CP-1145 Travis CI, sockjs-dart-client #8

merged 1 commit into from
Nov 25, 2015

Conversation

evanweible-wf
Copy link
Contributor

Issue

  • Need CI to release

Changes

  • Setup Travis CI

Areas of Regression

  • n/a

Testing

  • CI passes

Code Review

@trentgrover-wf
@maxwellpeterson-wf
@dustinlessard-wf
@jayudey-wf

@trentgrover-wf
Copy link

+1

1 similar comment
@maxwellpeterson-wf
Copy link
Member

+1

@evanweible-wf
Copy link
Contributor Author

@jayudey-wf ready for merge.

@jayudey-wf jayudey-wf changed the title Travis CI Travis CI, sockjs-dart-client Nov 25, 2015
@jayudey-wf jayudey-wf changed the title Travis CI, sockjs-dart-client CP-1145 Travis CI, sockjs-dart-client Nov 25, 2015
@jayudey-wf
Copy link
Contributor

QA Resource Approval: +10

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • passing CI on Travis
  • Unit test created/updated
  • All unit tests pass

Merging into master.

jayudey-wf added a commit that referenced this pull request Nov 25, 2015
CP-1145 Travis CI, sockjs-dart-client
@jayudey-wf jayudey-wf merged commit 944f9e1 into master Nov 25, 2015
@travisreed-wf
Copy link

rosie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants