-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEDX-1987: Only generate backwards-compatible output when necessary #52
Conversation
The example tests are timing out on stable and beta because the |
6ccd870
to
3e4e1be
Compare
This is passing CI now with the workarounds in place. |
lib/src/builder.dart
Outdated
final dartTestYaml = await buildStep.readAsString(dartTestYamlId); | ||
if (dartTestYaml.contains('test/dart_test.browser_aggregate.yaml')) { | ||
log.fine( | ||
'Found `test/dart_test.browser_aggregate.yaml` in `dart_test.yaml`, will generate it for backwards-compatibility.'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: What would you think about making this an info or warning log that includes a suggestion to update the dart_test.yaml file to reference the new file?
QA +1. I pulled this into wdesk_sdk and verified that the backwards compatible file is no longer created when running the tests in browser aggregation mode. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+10
@Workiva/release-management-p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Something recently started causing CI failures like https://github.com/Workiva/tasker-ui/actions/runs/11962147002 due to [INFO] build_web_compilers:entrypoint on test/templates/test_template.browser_aggregate_test.dart.browser_test.dart:Info: Compiling without sound null safety! |
FEDX-1987
In v3, we moved the output of the browser-aggregation test config from
test/dart_test.browser_aggregate.yaml
todart_test.browser_aggregate.yaml
(in the root). For backwards-compatibility, we continued to output to the deprecated location, too. Most consumers should already be including thedart_test.browser_aggregate.yaml
in the root instead of the copy from thetest/
directory, but if they aren't, it should be trivial to detect by readingdart_test.yaml
where it would need to be included.This PR makes that change: when
test/dart_test.browser_aggregate.yaml
is found indart_test.yaml
, the builder will output that file. Otherwise, it will not, and only the rootdart_test.browser_aggregate.yaml
will be generated.