Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP-4923 Stop using the deprecated stream #100

Merged
merged 1 commit into from
Aug 11, 2017

Conversation

dustyholmes-wf
Copy link
Contributor

This was causing two problems:

  1. If store is a mock this fails due to an argument error unless the mock is configured to return a stream for store.stream
  2. stream is deprecated and should not be used, plus it is only visible for testing.

With this, a mocked store now needs to stub listen rather than stream.

@aviary-wf
Copy link

aviary-wf commented Aug 11, 2017

Raven

Number of Findings: 0

@dustyholmes-wf
Copy link
Contributor Author

@Workiva/web-platform-pp

@codecov-io
Copy link

Codecov Report

Merging #100 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #100   +/-   ##
=======================================
  Coverage   96.77%   96.77%           
=======================================
  Files           5        5           
  Lines          62       62           
=======================================
  Hits           60       60           
  Misses          2        2
Impacted Files Coverage Δ
lib/src/component_common.dart 92.3% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cc44cc...61cb328. Read the comment docs.

@trentgrover-wf
Copy link
Contributor

@jayudey-wf ready for you + release

@rmconsole3-wf rmconsole3-wf changed the title Stop using the deprecated stream WP-4923 Stop using the deprecated stream Aug 11, 2017
@maxwellpeterson-wf
Copy link
Member

+10

  • CI passes

@maxwellpeterson-wf
Copy link
Member

QA +1

  • Dev +1's
  • Dev/QA +10 with detail of what was tested
  • Tests created/updated
    • Existing tests cover change
  • All tests pass

@Workiva/release-management-pp

@rmconsole-wf
Copy link
Contributor

+1 from RM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants