Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEA-317: Use github actions instead of travis for CI #164

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

kimlarson-wk
Copy link
Contributor

FEA-317

Motivation

Changes

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Frontend Architecture member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@evanweible-wf
Copy link
Contributor

We can ignore the CI failures on stable/beta/dev for now - I think we're hitting this issue: dart-lang/test#1620 - and the fix for that will require us being on a newer version of analyzer.

@kimlarson-wk kimlarson-wk force-pushed the FEA-317_UseGithubActions branch from aa297c4 to 209174d Compare June 16, 2022 15:27
@kimlarson-wk kimlarson-wk marked this pull request as ready for review June 16, 2022 15:27
@kimlarson-wk kimlarson-wk requested a review from a team June 16, 2022 15:28
@evanweible-wf
Copy link
Contributor

QA +1

  • CI passes for 2.13.4 and formatting

@kimlarson-wk kimlarson-wk changed the title Use github actions instead of travis for CI FEA-317: Use github actions instead of travis for CI Jun 16, 2022
@kimlarson-wk
Copy link
Contributor Author

@Workiva/release-management-pp ready for merge.

Copy link
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole5-wk rmconsole5-wk merged commit 2033aa5 into master Jun 16, 2022
@rmconsole5-wk rmconsole5-wk deleted the FEA-317_UseGithubActions branch June 16, 2022 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants