Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix w_common v2 breaking changes #165

Merged
merged 6 commits into from
Sep 8, 2022

Conversation

sourcegraph-wk
Copy link

w_common has a number of deprecations that are removed in v2. This batch attempts to
fix as many of the breaking changes as possible to prepare to move to v2.
Breaking Changes: https://github.com/Workiva/w_common/blob/master/w_common/CHANGELOG.md#200

Created by Sourcegraph batch change Workiva/fix_w_common_v2_breaking_changes.

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@robbecker-wf robbecker-wf changed the title Fix w_common v2 breaking changes remove deprecations and cut a v3 Sep 7, 2022
Copy link
Contributor

@evanweible-wf evanweible-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robbecker-wf I agree we should do this (cut a V3 with deprecations removed), but I think there's still value in addressing the w_common deprecations in the current major version of w_flux first so that we don't have to also upgrade to w_flux v3 in order to consume w_common V2.

@robbecker-wf robbecker-wf changed the title remove deprecations and cut a v3 Fix w_common v2 breaking changes Sep 7, 2022
@robbecker-wf robbecker-wf marked this pull request as ready for review September 8, 2022 03:29
@robbecker-wf
Copy link
Member

ok, I reverted to the minimal needed to address deprecated w_common use. The dart stable,dev, and beta checks are known to fail until we can upgrade the analyzer and test packages. From my investigations I think we need analyzer >=2 < 5 and >= test 1.21.0

@autobot-wf
Copy link

Skynet test results failed initially for this build but were approved by rob.becker
https://wf-skynet-hrd.appspot.com/apps/test/smithy/3891003/1
Approval message: newer versions of dart are known to fail, so the github actions check is overridden

@evanweible-wf
Copy link
Contributor

QA +1

@evanweible-wf
Copy link
Contributor

@Workiva/release-management-p

Copy link
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole6-wk rmconsole6-wk merged commit f7801b5 into master Sep 8, 2022
@rmconsole6-wk rmconsole6-wk deleted the batch/fedx/fix_w_common_v2_breaking_changes branch September 8, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants