-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix w_common v2 breaking changes #165
Fix w_common v2 breaking changes #165
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robbecker-wf I agree we should do this (cut a V3 with deprecations removed), but I think there's still value in addressing the w_common deprecations in the current major version of w_flux first so that we don't have to also upgrade to w_flux v3 in order to consume w_common V2.
ok, I reverted to the minimal needed to address deprecated w_common use. The dart stable,dev, and beta checks are known to fail until we can upgrade the analyzer and test packages. From my investigations I think we need analyzer >=2 < 5 and >= test 1.21.0 |
Skynet test results failed initially for this build but were approved by rob.becker |
QA +1 |
@Workiva/release-management-p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
w_common has a number of deprecations that are removed in v2. This batch attempts to
fix as many of the breaking changes as possible to prepare to move to v2.
Breaking Changes: https://github.com/Workiva/w_common/blob/master/w_common/CHANGELOG.md#200
Created by Sourcegraph batch change
Workiva/fix_w_common_v2_breaking_changes
.