Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEA-2770 FEA-2772 Action v2 type migration #195

Merged
merged 16 commits into from
Jan 12, 2024

Conversation

sorenthompson-wk
Copy link
Contributor

Motivation

W_flux Action to ActionV2 codemod

Changes

make codemod to migrate Action to ActionV2

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Frontend Architecture member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

w_flux_codemod/lib/src/action_v2_suggestor.dart Outdated Show resolved Hide resolved
w_flux_codemod/lib/src/action_v2_suggestor.dart Outdated Show resolved Hide resolved
w_flux_codemod/lib/src/action_v2_suggestor.dart Outdated Show resolved Hide resolved
w_flux_codemod/lib/src/action_v2_suggestor.dart Outdated Show resolved Hide resolved
w_flux_codemod/README.md Outdated Show resolved Hide resolved
evanweible-wf
evanweible-wf previously approved these changes Dec 19, 2023
Copy link
Contributor

@evanweible-wf evanweible-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good to me! Let's run it in a few more repos to see if we can catch any other edge cases. Once we feel good about that, we can get this merged and released.

@sorenthompson-wk sorenthompson-wk marked this pull request as ready for review January 3, 2024 20:36
w_flux_codemod/bin/action_v2_migrate.dart Outdated Show resolved Hide resolved
w_flux_codemod/bin/action_v2_migrate.dart Show resolved Hide resolved
w_flux_codemod/lib/src/utils.dart Outdated Show resolved Hide resolved
w_flux_codemod/test/action_v2_suggestor_test.dart Outdated Show resolved Hide resolved
@evanweible-wf
Copy link
Contributor

LGTM! I ran this in wdesk_sdk and graph_app again and it works great! Had to make two manual changes in wdesk_sdk, but none in graph_app. Let's ship it!

@evanweible-wf
Copy link
Contributor

QA +1

@evanweible-wf
Copy link
Contributor

@Workiva/release-management-p

@sorenthompson-wk
Copy link
Contributor Author

@Workiva/release-management-p send it

Copy link
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole7-wk rmconsole7-wk merged commit 12e7fbd into master Jan 12, 2024
6 checks passed
@rmconsole7-wk rmconsole7-wk deleted the ActionV2-type-migration branch January 12, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants