Open
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Switches sample date generation from a monthly first-of-month time_static resource (built from a dynamic timestamp expression that caused churn) to a long-lived time_rotating resource to reduce unnecessary Terraform plan diffs. This introduces a controlled annual rotation and aligns with the stated breaking change requiring Terraform 1.7.x.
- Replace time_static month_start with time_rotating example_timestamp (rotation_days = 365)
- Update module input example_api_calls_sample_date to use the new rotating resource ID
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WARNING: breaking change, needs to wait for next version that permits breaking changes (target 0.6.x)
Fixes
time_rotatinginstead oftime_staticwrapping a function call, as truncation done in the expression isn't sufficient enough to stop Terraform from thinking there's a changeChange implications