Skip to content

improve OAuth token refresh #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eschultink merged 11 commits into from
Nov 11, 2025

fix compile

982d5f9
Select commit
Loading
Failed to load commit list.
Merged

improve OAuth token refresh #1037

fix compile
982d5f9
Select commit
Loading
Failed to load commit list.
Cursor / Cursor Bugbot completed Nov 11, 2025 in 2m 40s

Bugbot Review

Bugbot Analysis Progress (2m 42s elapsed)

✅ Gathered PR context (2s)
✅ Analyzed code changes (1s)
✅ Completed bug detection — 4 potential bugs found (2m 15s)
✅ Validation and filtering completed (0s)
✅ Posted analysis results — 1 bug reported (24s)
✅ Analysis completed successfully (0s)

Final Result: Bugbot completed review and found 1 potential issue

Request ID: serverGenReqId_95cde4e1-0886-4985-939f-57022be12c85

Details

Bug: Missing Return: Logic Flow Violation

Missing return statement before Optional.empty() at line 120. When property.isEnvVarOnly() is true, execution continues instead of returning early, causing the method to attempt reading from Secret Manager for env-var-only properties, which violates the intended behavior and may result in unexpected errors or incorrect values being returned.

java/impl/gcp/src/main/java/co/worklytics/psoxy/SecretManagerConfigService.java#L118-L121

psoxy/java/impl/gcp/src/main/java/co/worklytics/psoxy/SecretManagerConfigService.java

Lines 118 to 121 in 982d5f9

@Override
public Optional<String> getConfigPropertyAsOptional(ConfigProperty property) {
if (property.isEnvVarOnly()) {
Optional.empty();

Fix in Cursor Fix in Web

View more details on Cursor