Skip to content

prep v0.5.12#1046

Merged
eschultink merged 11 commits intorc-v0.5.12from
s212-prep-v0.5.12
Nov 12, 2025
Merged

prep v0.5.12#1046
eschultink merged 11 commits intorc-v0.5.12from
s212-prep-v0.5.12

Conversation

@eschultink
Copy link
Member

Fixes

  • the mvn plugins added for distribution of some proxy libs via Github were causing build issues
  • sbom stuff wasn't working

Features

  • mvn reactor build in build.sh; seems like it should work better ...

Change implications

  • dependencies added/changed? yes

    • Several Maven plugins causing build errors have been dropped, and the reactor build approach is being utilized to improve robustness. These changes may affect how dependencies and modules are built and should be reviewed for impact on the build process.
  • something important to note in future release notes? no

  • breaking changes? no

@cursor
Copy link

cursor bot commented Nov 11, 2025

You have run out of free Bugbot PR reviews for this billing cycle. This will reset on December 10.

To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR prepares version 0.5.12 by addressing build issues and improving the Maven reactor build approach. The changes primarily focus on fixing problematic Maven plugins that were causing build failures and enhancing the SBOM generation process.

Key Changes:

  • Removed Maven source and javadoc plugins that were causing build issues from the parent POM
  • Implemented Maven reactor build strategy to build dependencies in correct order
  • Updated SBOM generation script to use the new build approach
  • Corrected documentation comment for ConfigValueVersion

Reviewed Changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
java/pom.xml Removed maven-source-plugin and maven-javadoc-plugin that were causing build issues
tools/build.sh Implemented Maven reactor build approach with proper dependency ordering
tools/release/generate-sbom.sh Updated to use new build.sh approach before SBOM generation
java/core/src/main/java/co/worklytics/psoxy/gateway/ConfigService.java Fixed comment describing version identifier type
docs/aws/sbom.json Updated SBOM with new version numbers and dependency hashes
Files not reviewed (1)
  • tools/psoxy-test/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

fi

# Convert to absolute path if relative
if [[ ! "$JAVA_SOURCE_ROOT" = /* ]]; then
Copy link

Copilot AI Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cd command could fail if the directory doesn't exist, which would cause the script to exit due to 'set -e'. Consider adding a check for directory existence with an informative error message before attempting to cd.

Suggested change
if [[ ! "$JAVA_SOURCE_ROOT" = /* ]]; then
if [[ ! "$JAVA_SOURCE_ROOT" = /* ]]; then
if [[ ! -d "${JAVA_SOURCE_ROOT}" ]]; then
printf "${RED}Error: Directory '${JAVA_SOURCE_ROOT}' does not exist.${NC}\n"
exit 1
fi

Copilot uses AI. Check for mistakes.
@eschultink eschultink merged commit 1a56a8b into rc-v0.5.12 Nov 12, 2025
48 checks passed
@eschultink eschultink deleted the s212-prep-v0.5.12 branch November 12, 2025 14:28
eschultink added a commit that referenced this pull request Nov 12, 2025
* Bump org.apache.httpcomponents.client5:httpclient5 in /java/gateway-core

Bumps [org.apache.httpcomponents.client5:httpclient5](https://github.com/apache/httpcomponents-client) from 5.4.1 to 5.4.3.
- [Changelog](https://github.com/apache/httpcomponents-client/blob/rel/v5.4.3/RELEASE_NOTES.txt)
- [Commits](apache/httpcomponents-client@rel/v5.4.1...rel/v5.4.3)

---
updated-dependencies:
- dependency-name: org.apache.httpcomponents.client5:httpclient5
  dependency-version: 5.4.3
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>

* prep v0.5.12

* Salesforce rules refresh (#1039)

* Update rules

* Support example with POST

* bump many dependencies (#1038)

* apache commons codec to 1.19.0

* more dep updates

* webhook collector auth perf (#1036)

* add logic to keep lambdas warm

* fix style

* init public keys in mem for webhook collectors on start-up

* aws replay tool (#1034)

* aws replace tool

* add documentation

* webhook collector output prefix support  (#1035)

* improve webhook collector mode configuration

* support webhook output prefix

* fix style

* fix path stuff

* fix missed rename

* fix various test issues

* gmail empty header fix (#1040)

* deal with empty header case more correctly; that's quite clearly a bug

* add test of empty CC case

* GCP VPC doc improvements (#1042)

* improve GCP vpc docs + conditions

* fix style, unrelated

* improve error feedback on network connectivity issues

* doc that GCP VPC needs external connectivity via router/nat for non-google sources

* move validation up to dop

* try to skip compile in tests

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* fix some references to role constants (#1043)

* config to deploy packages as mvn libs via GitHub Packages (#1041)

* improve OAuth token refresh (#1037)

* interface to secret store to get multiple versions of things

* refactor how token refreshin works, so potentially more proactive / better re-use

* pick most recent token based on expirationDate

* cr feedback

* fix refactor

* remove stray bracket

* Update java/core/src/main/java/co/worklytics/psoxy/gateway/impl/oauth/OAuthRefreshTokenSourceAuthStrategy.java

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update java/core/src/main/java/co/worklytics/psoxy/gateway/impl/CompositeConfigService.java

Co-authored-by: aperez-worklytics <75276364+aperez-worklytics@users.noreply.github.com>

* drop sort on lastAccessDate; only date-level granularity, so why bother

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: aperez-worklytics <75276364+aperez-worklytics@users.noreply.github.com>

* more psoxy constants (#1044)

* expose more outputs relevant to gcp-hosted deployments

* gcp min perms to host

* expose gcp network roles, for completenes

* doc gcp vpc roles

* doc that Project IAM Admin is required

* fix docs

* Update infra/modules/psoxy-constants/main.tf

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update infra/modules/psoxy-constants/outputs.tf

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update docs/gcp/vpc.md

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* prep v0.5.12 (#1046)

* fix bad comment

* try to make sbom stuff more robust

* drop mvn plugins that are problematic, see to cause build errors

* use reactor build

* sboms

* fix sbom generation

* update package-lock in psoxy-test

* fix gcp release artifact script

* prompt user if gcp artifact has already been published

* prompt user if aws artifact has already been published

* warn if we're NOT running in the expected place

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: aperez-worklytics <75276364+aperez-worklytics@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants