Skip to content

Comments

tech debt v0.5.17 #1101

Open
eschultink wants to merge 15 commits intorc-v0.5.18from
s218-tech-debt
Open

tech debt v0.5.17 #1101
eschultink wants to merge 15 commits intorc-v0.5.18from
s218-tech-debt

Conversation

@eschultink
Copy link
Member

@eschultink eschultink commented Feb 2, 2026

Fixes

  • inconsistent doc styling

Features

  • clean up compiler warnings, etc.

Logistics

Change implications

  • dependencies added/changed? no
  • something important to note in future release notes?
    • No significant changes affecting future releases.
    • No actions required in terraform plan/apply as these changes are primarily focused on code cleanup.
    • No breaking changes introduced.


Note

Medium Risk
Mostly build/docs and warning-suppression changes, but it also touches rule deserialization defaults (notably ColumnarRules delimiter) and Maven deployment behavior, which could affect packaging and bulk CSV parsing if misconfigured.

Overview
Improves release publishing by passing GITHUB_TOKEN into actions/setup-java and adjusting Maven deploy defaults so the root java build skips deployment while gateway-core/core explicitly allow it.

Reduces Java compiler/linter noise by adding targeted @SuppressWarnings (deprecated API usage, unchecked generics) and replacing Lombok @NoArgsConstructor with explicit no-args constructors for several Jackson-deserialized rule models; also changes ColumnarRules delimiter handling to default safely when unset.

Adds small developer convenience scripts under infra/examples-dev/gcp/ and normalizes beta formatting in docs/README.md.

Written by Cursor Bugbot for commit 52f0a9d. This will update automatically on new commits. Configure here.

@eschultink eschultink self-assigned this Feb 2, 2026
@eschultink eschultink changed the title S218 : tech debt tech debt v0.5.17 Feb 2, 2026
Base automatically changed from rc-v0.5.17 to main February 10, 2026 20:53
@eschultink eschultink changed the base branch from main to rc-v0.5.18 February 10, 2026 21:09
@eschultink eschultink marked this pull request as ready for review February 10, 2026 21:14
@eschultink eschultink requested review from aperez-worklytics, Copilot and jlorper and removed request for aperez-worklytics February 10, 2026 21:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@NonNull Pseudonymizer pseudonymizer) throws IOException {
CSVFormat inputCSVFormat = CSVFormat.DEFAULT.builder()
.setDelimiter(rules.getDelimiter())
.setDelimiter(ObjectUtils.firstNonNull(rules.getDelimiter(), ColumnarRules.DEFAULT_DELIMITER))
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty delimiter can crash CSV sanitizer

Medium Severity

ColumnarRules.delimiter is now a String, but sanitize() passes it directly to CSVFormat.Builder.setDelimiter(...) without checking for empty values. An empty YAML delimiter now reaches runtime and can throw, causing bulk sanitization to fail instead of falling back or rejecting config earlier.

Additional Locations (1)

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant