Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Glean (beta) connector to the Psoxy ecosystem, wiring it into the Java rule bundle, Terraform connector specs/modules, and published documentation/examples so it can be configured and tested consistently like existing connectors.
Changes:
- Added Glean sanitization rules + Java test coverage based on example API responses.
- Integrated Glean into Terraform connector specs/modules, including a new
glean_instance_namevariable and usage intarget_host. - Updated generated test scripts to safely print JSON bodies for POST examples.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| java/core/src/test/java/co/worklytics/psoxy/rules/glean/GleanTests.java | Adds rules test harness + invocation examples for Glean endpoints. |
| java/core/src/main/java/co/worklytics/psoxy/rules/glean/PrebuiltSanitizerRules.java | Adds Glean prebuilt rules loader and default map entry. |
| java/core/src/main/java/co/worklytics/psoxy/rules/PrebuiltSanitizerRules.java | Registers Glean rules into the global default rules map. |
| infra/modules/worklytics-connectors/variables.tf | Introduces glean_instance_name input variable for deployments. |
| infra/modules/worklytics-connectors/main.tf | Passes glean_instance_name through to connector-specs module. |
| infra/modules/worklytics-connector-specs/variables.tf | Adds glean_instance_name variable to specs module. |
| infra/modules/worklytics-connector-specs/main.tf | Defines the Glean connector spec (host, auth strategy, example requests, TODO instructions). |
| infra/modules/worklytics-connector-specs/docs/glean/instructions.tftpl | Adds Terraform-rendered setup instructions for providing the Glean token. |
| infra/modules/gcp-psoxy-rest/test_script.tftpl | Escapes quotes when printing POST example bodies in the test helper script. |
| infra/modules/aws-psoxy-rest/test_script.tftpl | Same POST-body escaping improvement for AWS test helper script. |
| infra/examples-dev/gcp/misc-data-source-variables.tf | Adds glean_instance_name + validation check for dev examples. |
| infra/examples-dev/gcp/main.tf | Wires glean_instance_name into the dev GCP example module call. |
| infra/examples-dev/aws/misc-data-source-variables.tf | Adds glean_instance_name + validation check for dev examples. |
| infra/examples-dev/aws/main.tf | Wires glean_instance_name into the dev AWS example module call. |
| docs/sources/glean/glean.yaml | Defines allowed endpoints + transforms/schema for Glean responses. |
| docs/sources/glean/example-api-responses/sanitized/list-entities-response.json | Adds sanitized fixture for listentities. |
| docs/sources/glean/example-api-responses/sanitized/insights-response.json | Adds sanitized fixture for insights. |
| docs/sources/glean/example-api-responses/original/list-entities-response.json | Adds original fixture for listentities. |
| docs/sources/glean/example-api-responses/original/insights-response.json | Adds original fixture for insights. |
| docs/sources/glean/README.md | Adds connector documentation, setup, and required scopes. |
| docs/SUMMARY.md | Adds Glean to the docs navigation. |
| docs/README.md | Adds Glean row to the connector/scopes table (and reformats the table block). |
| CHANGELOG.md | Notes the new Glean connector in release notes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| | Source | Details + Examples | API Permissions / Scopes | | ||
| |---------------------------|--------------------------------------------------------------------------|------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| | Asana | [sources/asana](sources/asana/README.md) | a [Service Account](https://asana.com/guide/help/premium/service-accounts) (provides full access to Workspace) | | ||
| | Claude Code *beta* | [sources/anthropic/claude-code](sources/anthropic/claude-code/README.md) | | API Key | |
There was a problem hiding this comment.
This Markdown table is defined as 3 columns, but the Claude Code *beta* row has an extra | API Key cell, which breaks the table rendering. Please collapse it into the third column (e.g., make the scopes cell say API Key) so all rows have the same number of columns.
Suggested change
| | Claude Code *beta* | [sources/anthropic/claude-code](sources/anthropic/claude-code/README.md) | | API Key | | |
| | Claude Code *beta* | [sources/anthropic/claude-code](sources/anthropic/claude-code/README.md) | API Key | |
Comment on lines
+14
to
+20
| final RulesTestSpec rulesTestSpec = RulesTestSpec.builder() | ||
| .defaultScopeId("glean") | ||
| .sourceKind("glean") | ||
| .exampleApiResponsesDirectoryPath("example-api-responses/original/") | ||
| .exampleSanitizedApiResponsesPath("example-api-responses/sanitized/") | ||
| .checkUncompressedSSMLength(false) | ||
| .build(); |
There was a problem hiding this comment.
This method overrides RulesBaseTestCase.getRulesTestSpec; it is advisable to add an Override annotation.
| @Getter | ||
| public class GleanTests extends JavaRulesTestBaseCase { | ||
|
|
||
| final RESTRules rulesUnderTest = PrebuiltSanitizerRules.GLEAN; |
There was a problem hiding this comment.
This method overrides RulesBaseTestCase.getRulesUnderTest; it is advisable to add an Override annotation.
Merged
eschultink
approved these changes
Feb 24, 2026
infra/modules/worklytics-connector-specs/docs/glean/instructions.tftpl
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for Glean Connector.
Adding test, docs, spec.
Fixes
Features
Psoxy connector
Logistics
Change implications
CHANGELOG.mdanything that will show up interraform plan/applythat isn'tobviously a no-op?
alpha, requires major versionchange