Fix a bug causing … is converted to "", "", "…" #121

sorami · 2020-06-02T00:56:41Z

Apply the same fix as this PR WorksApplications/Sudachi#118 for Java implementation.

Related: #120

When there are more tokens than the original, due to the normalization, set the original to the first output token, not the last.

For example, currently,

$ echo … | sudachipy
	補助記号,句点,*,*,*,*	.
	補助記号,句点,*,*,*,*	.
…	補助記号,句点,*,*,*,*	.
EOS

This will be fixed to

$ echo … | sudachipy
…	補助記号,句点,*,*,*,*	.
	補助記号,句点,*,*,*,*	.
	補助記号,句点,*,*,*,*	.
EOS

…h the original Java implementation

kazuma-t

No problem!

Change a variable name to modifield_to_original, to make it align wit…

e57eb40

…h the original Java implementation

sorami self-assigned this Jun 2, 2020

sorami added 3 commits June 2, 2020 10:08

Fix a bug causing … is converted to "", "", "…"

202dc1a

Fix tests for according to the new replace method

faeba33

Fix comment format

360d9e9

sorami requested a review from kazuma-t June 2, 2020 01:30

sorami marked this pull request as ready for review June 2, 2020 01:30

kazuma-t approved these changes Jun 2, 2020

View reviewed changes

sorami merged commit 1a6649b into develop Jun 2, 2020

sorami deleted the fix-cdots branch June 2, 2020 03:24

Provide feedback