Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor MSI parameters for scripted installations #133

Open
pgalbraith opened this issue Feb 25, 2019 · 2 comments
Open

Honor MSI parameters for scripted installations #133

pgalbraith opened this issue Feb 25, 2019 · 2 comments

Comments

@pgalbraith
Copy link

The MSI installer seems to use the parameter AUTOUPDATE to determine if autoupdates should be enabled, but passing AUTOUPDATE=0 as a parameter to the installer gets ignored and AUTOUPDATE is changed from 0 -> 1 during the install. It would be nice if the AUTOUPDATE=0 value passed on the command line at install time would be honored by the installer.

Similarly for the legacy installer both AUTOUPDATE=0 and LAUNCHEXCELADDIN=0 are not honored from the command line.

@pkgw
Copy link
Contributor

pkgw commented Mar 26, 2019

CC @astrojonathan, @philrosenfield for the planned Windows release.

pkgw added a commit to pkgw/wwt-windows-client that referenced this issue Jan 5, 2022
Following up (finally) issue WorldWideTelescope#133. I'll write up a summary there.
Basically there is no good way to get a sensible user experience
becaue (1) checkboxes only work with properties being defined or
undefined and (2) the Visual Studio installer generation has a bug
that prevents checkbox properties from being controlled from the
command line. Subsequent commits will address the second issue.
@pkgw
Copy link
Contributor

pkgw commented Jan 5, 2022

It's taken a while but I think I have a fix for this issue! It ended up being a real mess -- gritty details in #194. The candidate fix should make it into the next beta release, which I want to put out soon so that I can test the auto-updating functionality more generally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants