Fix: invalid results

Would-You-Bot · Oct 1, 2023 · a52a573 · a52a573
1 parent ba22875
commit a52a573
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 4 deletions.
diff --git a/src/buttons/result.js b/src/buttons/result.js
@@ -13,6 +13,11 @@ module.exports = {
     const customId = interaction.customId.split("_");
 
     const votingResults = await client.voting.getVotingResults(customId[1]);
+    if (!votingResults) return await interaction.reply({
+        content: "Unable to fetch results.",
+        ephemeral: true,
+      })
+
 
     const resultEmbed = new EmbedBuilder()
       .setImage(votingResults.chart)

diff --git a/src/languages/en_EN.json b/src/languages/en_EN.json
@@ -295,7 +295,8 @@
     "Yes": "Yes",
     "No": "No",
     "Vote": "Vote: ",
-    "VotingResults": "Voting Results"
+    "VotingResults": "Voting Results",
+    "VotingResultsError": "Unable to fetch results."
   },
   "HigherLower": {
     "description": "Do you think that **{keyword}** has higher or lower searches than **{history}**?\n\n Image source: **[Image 1]({source})** | **[Image 2]({source2})**",

diff --git a/src/util/votingHandler.js b/src/util/votingHandler.js
@@ -102,7 +102,12 @@ module.exports = class Voting {
     };
   }
 
-  getVoting(id) {
+  async getVoting(id) {
+    if (!this._cache.get(id))
+      return await voteSchema.findOne({
+        id: id
+      });
+
     return this._cache.get(id);
   }
 
@@ -115,7 +120,7 @@ module.exports = class Voting {
   }
 
   async addVote(id, userId, option = 1) {
-    const vote = this.getVoting(id);
+    const vote = await this.getVoting(id);
     if (!vote) return false;
 
     const options = ["op_one", "op_two"];
@@ -133,7 +138,7 @@ module.exports = class Voting {
   }
 
   async getVotingResults(id) {
-    const vote = this.getVoting(id);
+    const vote = await this.getVoting(id);
     if (!vote) return false;
 
     let g;