Fortius Antifier v4.1.b for #121 #147 #164 #170
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WouterJD
changed the title
IlTulipano
approved these changes
Dec 17, 2020
| rolldown = False | ||
| rolldown_time = 0 | ||
| ShortMessage = TacxTrainer.Message + " | Runoff - " | ||
| ShortMessage = "Tacx Trainer Runoff - " |
There was a problem hiding this comment.
Which one of the messages is meant to be displayed? Currently the latter will take precedence.
There was a problem hiding this comment.
Agree; first message uses the "standard" but is quite long.
Second message is as suggested by CyclingFlow and indeed replaces the first (could be commented for clarity)
|
Obsolete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented:
Improve run-off procedure (see issue #147); runoff procedure structured and parameterized.
Ignore head unit buttons (see issue #164); main window can only be closed from GUI.
ANT Remote Control Support (see issue #121); UP / SELECT / DOWN button can be used to replace head unit buttons Up / OK / Down.
Thanks to @cyclingflow and @switchabl for input