Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added addon message for SMSG_SPELL_FAILED_OTHER #305

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zelazrgn
Copy link

@zelazrgn zelazrgn commented May 5, 2023

Ugly solution for #255

Since SPELL_CAST_FAILED is not triggered by SMSG_SPELL_FAILED_OTHER for some reason

Hopefully there is a better way to fix it.

I'm not sure if the ToUnitGUID is correct and I still need to add things like pets

@ratkosrb
Copy link
Collaborator

ratkosrb commented May 6, 2023

We shouldn't have Hermes send custom addon messages.

@zelazrgn
Copy link
Author

zelazrgn commented May 6, 2023

I added one of these addon messages as a workaround for #250

I don't like the solution for aura refresh as much, it's hooking into SMSG_SPELL_GO but only if it is an AuraSpells and it calls it for each hit target since I don't want to worry about max message length.

Does this seem like a potential performance issue?

@zelazrgn
Copy link
Author

zelazrgn commented May 9, 2023

I'm looking into handling this the proper way using SMSG_SPELL_INTERRUPT_LOG

From testing on classic era, castbar addons don't detect players cancelling a cast, only when they are interrupted. Let me know if this is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants