Fix for a bug causing walking to be activated by overlapping CC on vmangos servers. #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…angos servers. The modern client sends the falling flag in every MOVE_SPLINE_DONE packet and this can trigger the movement rooted condition in the vmangos anticheat if the player is rooted at the end of the spline movement. Simply removing the flag should fix the issue and since the 1.12 doesn't seem to use the falling flag in the spline done packets, it shouldn't cause any problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modern client sends the falling flag in every MOVE_SPLINE_DONE packet and this can trigger the movement rooted condition in the vmangos anticheat if the player is rooted at the end of the spline movement. If the anticheat is set up to reject the movement it restores the previous movement flags, which include walking for auras with the confuse mechanic like blind, polymorph, or scatter shot. Simply removing the flag should fix the issue and since the 1.12 doesn't seem to use the falling flag in the spline done packets, it shouldn't cause any problems.
There are other ways this bug can be triggered, but those are most likely caused by an issue in the anticheat code and happen even on the vanilla client.
fixes #223, fixes #189