Replace bootstrap related local libraries with npm dependencies #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have replaced bootstrap related local libraries with npm dependencies, namely
bootstrap
,bootstrap-dialog
andselectize
.I have kept the same versions of
bootstrap
andbootstrap-dialog
, but I have upgradedselectize
from 0.12.1 to 0.14.0., because:selectize
0.12.1 (at least its npm version) has dependenciesmicroplugin
andsifter
that need to be provided by us (they already are, but not explicitly in commons package.json) and their paths need to be explicitly mentioned in downstream project's require configuration (forgerock-ui-mock/src/main.js
).@selectize/selectize
since 0.14.0 (package was renamed since 0.13.x), so we don't need to care about them. This is also the only major breaking change since 0.12.1, so nothing should break with this upgrade (see changelog).I have quickly tested the mock project and everything seems to work fine as it did before.