Template mailer settings query

[kat-ms]

Great project, have enjoyed using it - thanks!

I've got a query about some of the mailer settings that are used in the project:

It looks like there's an environment variable, SEND_EMAIL checked here:

create-rust-app/template/backend/mail/mod.rs

Line 27 in 321b726

let actually_send: bool = env::var("SEND_EMAIL", "false").eq("true");

But further down there is some validation that looks for a different environment variable SEND_MAIL:

create-rust-app/template/backend/mail/mod.rs

Line 65 in 321b726

if std::env::var("SEND_EMAIL").is_err() || std::env::var("SEND_MAIL").unwrap().eq("true") {

Was it intended for there to be two different settings to control separate behaviours? The check also appears to print an error message (that at face value sounds contradictory) if SEND_MAIL is set to true.

[Wulf]

hey @katherine-sussol , thanks for reporting this!

That's a bug 😅. (It should be "SEND_MAIL")

Also, there should be a ! in front of std::env::var("SEND_MAIL").unwrap().eq("true"). It's on this line:
https://github.com/Wulf/create-rust-app/blob/main/template/backend/mail/mod.rs#L65

Feel free to create a PR, otherwise, I can do it as well :-)

We're going to make some changes which make it easier for these bug fixes to propagate to existing create-rust-app projects.