Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor refactoring and fixes: dev module #373

Merged
merged 4 commits into from
May 12, 2024
Merged

minor refactoring and fixes: dev module #373

merged 4 commits into from
May 12, 2024

Commits on May 3, 2024

  1. fix(dev): don't panic in is_connected if we couldn't get a connecti… 

    …on to the db
    @AnthonyMichaelTDM
    AnthonyMichaelTDM committed May 3, 2024
    Configuration menu
    Copy the full SHA
    cb58e76 View commit details
    Browse the repository at this point in the history

  2. perf: assigning the result of Clone::clone() may be inefficient 

    https://rust-lang.github.io/rust-clippy/master/index.html#/assigning_clones
    @AnthonyMichaelTDM
    AnthonyMichaelTDM committed May 3, 2024
    Configuration menu
    Copy the full SHA
    5077bee View commit details
    Browse the repository at this point in the history

  3. refactor(dev): migrate_db fn to return result instead of ( success, o… 

    …ptional error_message ) tuple.

We aren't in Go, we have better error handling available so should take advantage of it

TODO: There are more cases in this function where it may be better to propagate errors rather than panicing
    @AnthonyMichaelTDM
    AnthonyMichaelTDM committed May 3, 2024
    Configuration menu
    Copy the full SHA
    eb51c59 View commit details
    Browse the repository at this point in the history

  4. refactor(dev): listen_for_signals, rename variables and refactor erro… 

    …r handling

https://rust-lang.github.io/rust-clippy/master/index.html#/never_loop

the loop only actually runs once, so an `if let` is a much more clear expression.
    @AnthonyMichaelTDM
    AnthonyMichaelTDM committed May 3, 2024
    Configuration menu
    Copy the full SHA
    ef930cd View commit details
    Browse the repository at this point in the history