Call yarn as "yarn.cmd" on Windows (fixes #53) #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Wulf
reviewed
Nov 11, 2022
Comment on lines
-83
to
+84
| name = "fullstack" | ||
| path = ".cargo/bin/fullstack.rs" | ||
| name = "run_yarn_fullstack" | ||
| path = ".cargo/bin/run_yarn_fullstack.rs" |
There was a problem hiding this comment.
is this rename necessary or were you trying to maintain the naming convention with tsync?
if it's not necessary, let's undo this change.
Comment on lines
-87
to
+88
| name = "tsync" | ||
| path = ".cargo/bin/tsync.rs" | ||
| name = "run_yarn_tsync" | ||
| path = ".cargo/bin/run_yarn_tsync.rs" |
There was a problem hiding this comment.
8.1.0 doesn't run tsync via yarn anymore nor does it use the global tsync binary.
Since you can uninstall tsync via cargo uninstall tsync and use cargo tsync normally, do you think this resolves the issue?
Comment on lines
+4
to
+8
| #[cfg(windows)] | ||
| pub const YARN_COMMAND: &'static str = "yarn.cmd"; | ||
|
|
||
| #[cfg(not(windows))] | ||
| pub const YARN_COMMAND: &'static str = "yarn"; |
Comment on lines
+5
to
+16
| #[cfg(windows)] | ||
| pub const YARN_COMMAND: &'static str = "yarn.cmd"; | ||
|
|
||
| #[cfg(not(windows))] | ||
| pub const YARN_COMMAND: &'static str = "yarn"; | ||
|
|
||
| pub fn main() -> Result<(), io::Error> { | ||
| let dir = env!("CARGO_MANIFEST_DIR"); | ||
|
|
||
| println!("Running `yarn tsync` in `$project_dir/frontend/`..."); | ||
|
|
||
| Command::new("yarn") | ||
| Command::new(YARN_COMMAND) |
There was a problem hiding this comment.
if you rebase, these changes won't be necessary :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also rename the binaries that call
yarnso that there are not two clashing binaries namedtsync.exe(see #53 (comment)).