Fix crash on dropped frame when buffer mapping hasn't completed yet #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JCapucho can you have a look at confirm whether this solves your problem? |
Wumpf
force-pushed
the
dropped-frames2
branch
from
cd94719
to
9c536d7
Compare
|
@Wumpf the changes work perfectly for me |
|
@JCapucho published 0.9.1 with the fix |
|
Thanks @Wumpf for pushing a new version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified alternative to fix in #18 and commented a bit what's happening on a frame drop (took me way too long to figure that out again). I decided to ignore the
BufferAsyncErrorafter all in the expectation that wgpu will soon be able to report aborted mappings. This should be safe since the only way to trigger this error is anunmapcall (and naturally, wgpu-profile owns all of these for the buffers in question), see https://www.w3.org/TR/webgpu/#dom-gpubuffer-unmapHowever, the error code are not yet exposed in wgpu, eagerly awaiting the resolution gfx-rs/wgpu#2939
PR comes with a regression test :)
(which gives a stable repro for the previous issue)