Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for version strings with multiple || #21

Merged
merged 1 commit into from
Mar 19, 2023
Merged

fix for version strings with multiple || #21

merged 1 commit into from
Mar 19, 2023

Conversation

hschapitz
Copy link
Contributor

@hschapitz hschapitz commented Mar 19, 2023 •
edited
Loading

without replaceAll it's not possible to use the script with a version string like
^7.4 || ~8.0.0 || ~8.1.0 || ~8.2.0

@hschapitz hschapitz requested a review from WyriHaximus as a code owner March 19, 2023 17:31
WyriHaximus added a commit that referenced this pull request Mar 19, 2023
@WyriHaximus
Have more than one double pipe in composer.json
67fcdac 
Refs: #21
@WyriHaximus WyriHaximus mentioned this pull request Mar 19, 2023
Merged
@WyriHaximus WyriHaximus added this to the v1.10.0 milestone Mar 19, 2023
WyriHaximus
WyriHaximus approved these changes Mar 19, 2023
View reviewed changes
Copy link
Owner

@WyriHaximus WyriHaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍. Will update the tests in a follow up PR to make sure this is covered.

@WyriHaximus WyriHaximus merged commit b332843 into WyriHaximus:main Mar 19, 2023
WyriHaximus added a commit that referenced this pull request Mar 19, 2023
@WyriHaximus
Have more than one double pipe in composer.json
9c24bc0 
Refs: #21
@WyriHaximus WyriHaximus added the bug Something isn't working label Mar 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WyriHaximus WyriHaximus WyriHaximus approved these changes

Assignees
No one assigned
Labels
bug Something isn't working JavaScript 🦏
Projects
None yet
Milestone
v1.9.1
Development

Successfully merging this pull request may close these issues.
2 participants
@hschapitz @WyriHaximus