Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improve python kernel #1375

Merged
merged 5 commits into from
Sep 25, 2023

Conversation

l1tok
Copy link
Contributor

@l1tok l1tok commented Aug 25, 2023

The details of this pr is covered in this issuecomment#148.

@open-digger-bot open-digger-bot bot added the kind/enhancement Category issues or prs related to enhancement. label Aug 25, 2023
@xgdyp
Copy link
Contributor

xgdyp commented Sep 5, 2023

Hi, since this is a breaking change, I'm wondering how to manage different versions of the kernel. So I think we can design a version control rule first.

@xgdyp
Copy link
Contributor

xgdyp commented Sep 18, 2023

I'll review it this week.

@l1tok l1tok force-pushed the refactor/ospp-refactor-python-kernel branch 2 times, most recently from 7c8e15a to 5369d86 Compare September 25, 2023 12:30
Delete config file

add __init__.py

add __init__.py

add .gitignore
@l1tok l1tok force-pushed the refactor/ospp-refactor-python-kernel branch from 5369d86 to 2b7b669 Compare September 25, 2023 12:33
@l1tok
Copy link
Contributor Author

l1tok commented Sep 25, 2023

In this file python_v2_sample, we can see a demo.

@xgdyp
Copy link
Contributor

xgdyp commented Sep 25, 2023

LGTM
/approve

@open-digger-bot open-digger-bot bot added the pull/approved If a pull is approved, it will be automatically merged label Sep 25, 2023
@xgdyp xgdyp merged commit 90ad91c into X-lab2017:master Sep 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or prs related to enhancement. pull/approved If a pull is approved, it will be automatically merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants