Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update faction class icon to use new hook from community highlander. #82

Merged
merged 1 commit into from
Apr 13, 2022
Merged

Update faction class icon to use new hook from community highlander. #82

merged 1 commit into from
Apr 13, 2022

Conversation

FearTheBunnies
Copy link

Pull request for issue #81 to add support for Highlander Issue #1134.

@Iridar Iridar merged commit cc1d3dd into X2CommunityCore:master Apr 13, 2022
@Iridar
Copy link

Iridar commented Apr 13, 2022

This PR had a minor mistake, Unit, not StateUnit, and AS_SetFaction, not AS_SetFactionIcon . In the future please make sure the submitted code at least compiles before opening a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Iridar Iridar Iridar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FearTheBunnies @Iridar