Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XGUnitNativeBase::TriggerOverrideProjectileInstance is bugged #1053

Closed
Iridar opened this issue Aug 7, 2021 · 0 comments · Fixed by #1179
Closed

XGUnitNativeBase::TriggerOverrideProjectileInstance is bugged #1053

Iridar opened this issue Aug 7, 2021 · 0 comments · Fixed by #1179

Comments

@Iridar
Copy link
Contributor

Iridar commented Aug 7, 2021

Relevant code.

Original issue: #829

The docs mention that the purpose of this override is to allow listeners to override parameters of the original function, but the override obviously doesn't function like that, as none of the override arguments are set as out, and are not updated after triggering the event.

Moreover, the bPreventProjectileSpawning parameter is not updated after triggering the event either, so the advertised functionality of being able to prevent the projectile from spawning doesn't work.

This can be addressed in two ways:

  1. Conservative - update bPreventProjectileSpawning and correct docs by removing the "override parameters" line.
  2. Expansive - convert all override arguments to out and update all of them after triggering the event.

Suggestions, preference?

Iridar pushed a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue May 14, 2023
Iridar pushed a commit that referenced this issue May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant