Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass Chosen abilities descriptions through XEXPAND #1096

Closed
GafrieGithub opened this issue Nov 28, 2021 · 2 comments · Fixed by #1174 or #1225
Closed

Pass Chosen abilities descriptions through XEXPAND #1096

GafrieGithub opened this issue Nov 28, 2021 · 2 comments · Fixed by #1174 or #1225
Labels
enhancement
Milestone
1.26.0

Comments

@GafrieGithub
Copy link

Similar to what was done in #566 for sitreps description, can Chosen strengths/weakness descriptions get the same change? Namely, changing using AbilityTemplate.LocLongDescription to its expanded version.
I believe it is needed in the following places:
UIChosenInfo - lines 150, 168;
UIChosenLevelUp - line 59;
UIChosenReveal - lines 55, 68.
@Xymanek Xymanek added this to the 1.24.0 milestone Nov 28, 2021
pledbrook added a commit to long-war-2/X2WOTCCommunityHighlander that referenced this issue Dec 7, 2021
@pledbrook
Expand tags for Chosen strengths/weaknesses screens
d4fffb0 
Modified `UIChosenReveal` and `UIChosenInfo` so that the strength and
weakness descriptions are passed through `ExpandString()`.

Fixes X2CommunityCore#1096.
@pledbrook pledbrook mentioned this issue Dec 7, 2021
Closed
@Xymanek Xymanek removed this from the 1.24.0 milestone Feb 26, 2022
Iridar pushed a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue May 14, 2023
@ps2guides
Implement Issue X2CommunityCore#1096
22aaaec
@Iridar Iridar mentioned this issue May 14, 2023
Merged
Iridar pushed a commit that referenced this issue May 21, 2023
@ps2guides @Iridar
Implement Issue #1096
054f7ce
@GafrieGithub
Copy link
Author

I originally pointed three places where descriptions needed to be expanded. But Peter's PR made change in only two places. And then Iridar's reimplementation left changes only in one place. I may be missing something but I am confused as to why. It was a long time since I looked into specifics of this, but AFAIR these three places are separate "screens", so to speak. And currently only one of these displays tags properly, so I believe this issue was closed prematurely.

@Iridar
Copy link
Contributor

Iridar commented Jul 4, 2023

You are correct. Currently only the UIChosenInfo is handled. Reopening.

@Iridar Iridar reopened this Jul 4, 2023
@Iridar Iridar added this to the 1.26.0 milestone Jul 4, 2023
@BlackDog86 BlackDog86 mentioned this issue Jul 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.26.0
3 participants
@Xymanek @Iridar @GafrieGithub