Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OverrideHitEffects event has inconsistent functionality / docs #1114

Closed
Iridar opened this issue Dec 31, 2021 · 0 comments · Fixed by #1115
Closed

OverrideHitEffects event has inconsistent functionality / docs #1114

Iridar opened this issue Dec 31, 2021 · 0 comments · Fixed by #1115
Assignees
@Iridar
Labels
bug-highlander

Comments

@Iridar
Copy link
Contributor

Iridar commented Dec 31, 2021

Relevant code

The docs for OverrideHitEffects event mention most tuple arguments as inout, but they're actually in, and cannot be modified by listeners. Effectively the event can be used only to disable the on-hit effects. So either docs or actual functionality need to be changed to match the other.
@Iridar Iridar self-assigned this Dec 31, 2021
Iridar added a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue Dec 31, 2021
@Iridar
Issue X2CommunityCore#1114 - update docs and functionality for Overri…
178ffa2 
…deHitEffects event.
@Iridar Iridar mentioned this issue Dec 31, 2021
Merged
Xymanek pushed a commit that referenced this issue Feb 7, 2022
@Iridar
Update docs and functionality for OverrideHitEffects event (#1115)
145e9da 
* Issue #1114 - update docs and functionality for OverrideHitEffects event.

* Improved docs and made `bIsUnitRuptured` into an out argument.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Iridar Iridar

Labels
bug-highlander
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update docs and functionality for OverrideHitEffects event Iridar/X2WOTCCommunityHighlander
1 participant
@Iridar