Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'OverrideMetaHitEffect' event #1116

Closed
Iridar opened this issue Dec 31, 2021 · 0 comments · Fixed by #1117
Closed

Add 'OverrideMetaHitEffect' event #1116

Iridar opened this issue Dec 31, 2021 · 0 comments · Fixed by #1117
Assignees
@Iridar

Comments

@Iridar
Copy link
Contributor

Iridar commented Dec 31, 2021

Issue #825 adds an event to override Hit Effects, but no such event was added to override Meta Hit Effect.

Regular Hit Effects include stuff like psionic flashes when projectiles collide with a Templar Parry, while Meta Hit Effect is responsible for playing (or not playing) the effect of blood gushing out of the unit that is being attacked.

Being able to override both regular Hit Effects and Meta Hit Effect is necessary for the use case of making an ability that blocks only a certain amount of damage, but mimics the original Parry otherwise.
@Iridar Iridar self-assigned this Dec 31, 2021
Iridar added a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue Dec 31, 2021
@Iridar
Issue X2CommunityCore#1116 - add 'OverrideMetaHitEffect' event.
eaf24eb
@Iridar Iridar mentioned this issue Dec 31, 2021
Merged
Xymanek pushed a commit that referenced this issue Feb 5, 2022
@Iridar
Add 'OverrideMetaHitEffect' event (#1117)
d414289 
* Issue #1116 - add 'OverrideMetaHitEffect' event.

* Fix function name call

* Implemented requested changes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Iridar Iridar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add 'OverrideMetaHitEffect' event Iridar/X2WOTCCommunityHighlander
1 participant
@Iridar