Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need event hook to handle doom being created by missions not on geoscape #550

Open
jmartinez989 opened this issue Jun 5, 2019 · 2 comments
Labels
enhancement needs-docs Needs documentation

Comments

@jmartinez989
Copy link
Contributor

There is a situation (specifically in Long War) where missions that generate doom (like alien facilities) can generate doom when not revealed. There is an issue with the current Highlander code that makes it so that doom is not properly updated when this happens.

An event based hook needs to be updated when the current doom of the alien HQ is acquired so that the doom from unrevealed events can be captured correctly.

@jmartinez989
Copy link
Contributor Author

I have an implementation of this. Just need to make a pull request.

jmartinez989 added a commit to long-war-2/X2WOTCCommunityHighlander that referenced this issue Jun 6, 2019
This change is add an event based hook to calcualte doom for any mods
(like LW2) that have missions that generate doom that could potentially
be not revealed causing doom generation updates to no be displayed
properly.
jmartinez989 added a commit to long-war-2/X2WOTCCommunityHighlander that referenced this issue Jun 6, 2019
This change is add an event based hook to calcualte doom for any mods
(like LW2) that have missions that generate doom that could potentially
be not revealed causing doom generation updates to no be displayed
properly.
@robojumper robojumper added the needs-docs Needs documentation label Jan 18, 2020
@Iridar
Copy link
Contributor

Iridar commented Jan 11, 2021

I wanted to add docs for this, but couldn't understand why it does what it does.

If the issue is with the doom not being updated when it should be, then shouldn't this implement an event listener that will force update doom when a specific event is triggered, and then have those LW missions or whatnot trigger that event to force update doom when they need to?

Instead, this issue triggers events to allow mods to override current doom. So mods can do what? Check if there is a hidden mission that has generated X additional doom up to this point? Seems backwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement needs-docs Needs documentation
Projects
None yet
Development

No branches or pull requests

4 participants