-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need event hook to handle doom being created by missions not on geoscape #550
Comments
I have an implementation of this. Just need to make a pull request. |
This change is add an event based hook to calcualte doom for any mods (like LW2) that have missions that generate doom that could potentially be not revealed causing doom generation updates to no be displayed properly.
This change is add an event based hook to calcualte doom for any mods (like LW2) that have missions that generate doom that could potentially be not revealed causing doom generation updates to no be displayed properly.
I wanted to add docs for this, but couldn't understand why it does what it does. If the issue is with the doom not being updated when it should be, then shouldn't this implement an event listener that will force update doom when a specific event is triggered, and then have those LW missions or whatnot trigger that event to force update doom when they need to? Instead, this issue triggers events to allow mods to override current doom. So mods can do what? Check if there is a hidden mission that has generated X additional doom up to this point? Seems backwards. |
There is a situation (specifically in Long War) where missions that generate doom (like alien facilities) can generate doom when not revealed. There is an issue with the current Highlander code that makes it so that doom is not properly updated when this happens.
An event based hook needs to be updated when the current doom of the alien HQ is acquired so that the doom from unrevealed events can be captured correctly.
The text was updated successfully, but these errors were encountered: