-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix smoke and poison targeting #669
Comments
This doesn't seem like an appropriate highlander change, since it's too specific a gameplay change. I don't know whether an event allowing mods to change the hit modifiers makes sense or whether mods should simply MCO the effect in that case. I still think the targeting/apply-to-world issue is a bug that should be fixed in the highlander to avoid the necessity of MCOs in that case. |
How would this interact with the existing fix mod? |
That MCOs the effect classes, so there shouldn't be any conflict. |
OK, so LW2 added a whole |
There is also an issue for smoke grenades where units are highlighted but their tiles are not: Only the units that are on highlighted tiles will actually get the smoke buff, so highlighting the other units is confusing to players (and just plain wrong). LW2 fixed that as well, so will include it in the pull request for this issue. |
Grenades that apply effects to the world, such as smoke grenades, are unreliable in their targeting because those effects are not always applied to tiles that are highlighted by targeting. This change adds two boolean config vars that, when true, fix that so that smoke and/or poison are applied to all the highlighted tiles. In addition, there are some instances where the targeting will highlight units without highlighting the tiles that they're on. This gives the impression that those units will be affected by the world effects (like smoke) when they won't. This changes adds a config array of grenade names, where any grenade in that array will not highlight units unless they are on highlighted tiles. Smoke grenades and bombs are the main candidates for this array, but mods may add other types. Resolves X2CommunityCore#669
Grenades that apply effects to the world, such as smoke grenades, are unreliable in their targeting because those effects are not always applied to the tiles highlighted by the targeting. This change adds two boolean config vars that, when true, fix this inconsistency so that smoke and/or poison are applied to all the highlighted tiles. In addition, there are some instances where the targeting will highlight units without highlighting the tiles that they're on. This gives the impression that those units will be affected by the world effects (like smoke) when they won't. This changes adds a config array of grenade names, where any grenade in that array will not highlight units unless they are on highlighted tiles. Smoke grenades and bombs are the main candidates for this array, but mods may add other types. Resolves X2CommunityCore#669
Grenades that apply effects to the world, such as smoke grenades, are unreliable in their targeting because those effects are not always applied to the tiles highlighted by the targeting. This change adds two boolean config vars that, when true, fix this inconsistency so that smoke and/or poison are applied to all the highlighted tiles. In addition, there are some instances where the targeting will highlight units without highlighting the tiles that they're on. This gives the impression that those units will be affected by the world effects (like smoke) when they won't. This changes adds a config array of grenade names, where any grenade in that array will not highlight units unless they are on highlighted tiles. Smoke grenades and bombs are the main candidates for this array, but mods may add other types. Resolves X2CommunityCore#669
This would port the LW2 changes to the highlander so that smoke and gas grenade targeting would match the tiles that are actually affected. It would remove the need for Reliable Smoke and its MCO.
The text was updated successfully, but these errors were encountered: