Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix smoke and poison targeting #669

Closed
pledbrook opened this issue Oct 26, 2019 · 5 comments · Fixed by #930
Closed

Fix smoke and poison targeting #669

pledbrook opened this issue Oct 26, 2019 · 5 comments · Fixed by #930

Comments

@pledbrook
Copy link
Contributor

This would port the LW2 changes to the highlander so that smoke and gas grenade targeting would match the tiles that are actually affected. It would remove the need for Reliable Smoke and its MCO.

@pledbrook
Copy link
Contributor Author

pledbrook commented Oct 26, 2019

This could also add the option to have smoke disable the flanking bonus from crit. Maybe?

This doesn't seem like an appropriate highlander change, since it's too specific a gameplay change. I don't know whether an event allowing mods to change the hit modifiers makes sense or whether mods should simply MCO the effect in that case.

I still think the targeting/apply-to-world issue is a bug that should be fixed in the highlander to avoid the necessity of MCOs in that case.

@Xymanek
Copy link
Member

Xymanek commented Oct 26, 2019

How would this interact with the existing fix mod?

@pledbrook
Copy link
Contributor Author

That MCOs the effect classes, so there shouldn't be any conflict.

@pledbrook
Copy link
Contributor Author

OK, so LW2 added a whole CheckForWorldEffectTileExclusion(out array<Actor> CurrentlyMarkedTargets, array<TTile>Tiles) function to X2TargetingMethod_Grenade to fix another issue with painting actors that won't be affected by the smoke/poison/other world effect.

@pledbrook
Copy link
Contributor Author

pledbrook commented Dec 24, 2020

There is also an issue for smoke grenades where units are highlighted but their tiles are not:

X2 smoke targeting bug

Only the units that are on highlighted tiles will actually get the smoke buff, so highlighting the other units is confusing to players (and just plain wrong). LW2 fixed that as well, so will include it in the pull request for this issue.

pledbrook added a commit to long-war-2/X2WOTCCommunityHighlander that referenced this issue Dec 25, 2020
Grenades that apply effects to the world, such as smoke grenades, are
unreliable in their targeting because those effects are not always
applied to tiles that are highlighted by targeting. This change adds two
boolean config vars that, when true, fix that so that smoke and/or
poison are applied to all the highlighted tiles.

In addition, there are some instances where the targeting will highlight
units without highlighting the tiles that they're on. This gives the
impression that those units will be affected by the world effects (like
smoke) when they won't. This changes adds a config array of grenade
names, where any grenade in that array will not highlight units unless
they are on highlighted tiles. Smoke grenades and bombs are the main
candidates for this array, but mods may add other types.

Resolves X2CommunityCore#669
pledbrook added a commit to long-war-2/X2WOTCCommunityHighlander that referenced this issue Apr 7, 2021
Grenades that apply effects to the world, such as smoke grenades, are
unreliable in their targeting because those effects are not always
applied to the tiles highlighted by the targeting. This change adds two
boolean config vars that, when true, fix this inconsistency so that
smoke and/or poison are applied to all the highlighted tiles.

In addition, there are some instances where the targeting will highlight
units without highlighting the tiles that they're on. This gives the
impression that those units will be affected by the world effects (like
smoke) when they won't. This changes adds a config array of grenade
names, where any grenade in that array will not highlight units unless
they are on highlighted tiles. Smoke grenades and bombs are the main
candidates for this array, but mods may add other types.

Resolves X2CommunityCore#669
Iridar pushed a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue May 24, 2021
Grenades that apply effects to the world, such as smoke grenades, are
unreliable in their targeting because those effects are not always
applied to the tiles highlighted by the targeting. This change adds two
boolean config vars that, when true, fix this inconsistency so that
smoke and/or poison are applied to all the highlighted tiles.

In addition, there are some instances where the targeting will highlight
units without highlighting the tiles that they're on. This gives the
impression that those units will be affected by the world effects (like
smoke) when they won't. This changes adds a config array of grenade
names, where any grenade in that array will not highlight units unless
they are on highlighted tiles. Smoke grenades and bombs are the main
candidates for this array, but mods may add other types.

Resolves X2CommunityCore#669
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants