Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change #400 #401 to Trigger on All Abilities #749

Closed
Onidotmoe opened this issue Jan 30, 2020 · 1 comment · Fixed by #957
Closed

Change #400 #401 to Trigger on All Abilities #749

Onidotmoe opened this issue Jan 30, 2020 · 1 comment · Fixed by #957

Comments

@Onidotmoe
Copy link
Contributor

Will allow mods to change the color of any Ability Icon for any arbitrary reason.

A pull request will come soon
@Onidotmoe Onidotmoe mentioned this issue Jan 30, 2020
Closed
@Onidotmoe
Copy link
Contributor Author

Added pull request #750

Onidotmoe added a commit to Onidotmoe/X2WOTCCommunityHighlander that referenced this issue Jan 31, 2020
@Onidotmoe
Changed the structure of X2CommunityCore#400 & X2CommunityCore#749 Co…
6dd8347 
…mpletely
Iridar pushed a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue Jan 14, 2021
@Onidotmoe
Changed the structure of X2CommunityCore#400 & X2CommunityCore#749 Co…
ea2d956 
…mpletely
@Iridar Iridar mentioned this issue Jan 14, 2021
Merged
Iridar pushed a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue Jan 14, 2021
@Onidotmoe
Changed how X2CommunityCore#400 worked to trigger an event for all ab…
f4dbf2e 
…ilities

Switched back to EnableMouseAutomaticColor as setting Colors directly would get overriden by default upon mouseover

Changed the structure of X2CommunityCore#400 & X2CommunityCore#749 Completely

Added Highlander Docs

Changed Documentation from inout to in on IsObjective

Make ability icon color override backwards compatible

Since the new event for overriding ability icon colors is fired for
every ability icon, not just objective abilities or abilities with a set
icon color, it may break existing listeners that assume that they are
only receiving abilities that match those criteria.

This change keeps the old event and introduces a new
'OverrideBothAbilityIconColors' event, which ensures maximum
compatibility.

I have also fixed the issue references in the HL-Docs lines: it doesn't
support multiple issue numbers per feature at the moment.
Iridar pushed a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue Jan 14, 2021
Implemented Issue X2CommunityCore#749
4d46359
Iridar pushed a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue Jan 14, 2021
@Onidotmoe
Implemented Issue X2CommunityCore#749
be99c42 
Switched back to EnableMouseAutomaticColor as setting Colors directly would get overriden by default upon mouseover

Changed the structure of X2CommunityCore#400 & X2CommunityCore#749 Completely

Added Highlander Docs

Changed Documentation from inout to in on IsObjective

Make ability icon color override backwards compatible

Since the new event for overriding ability icon colors is fired for
every ability icon, not just objective abilities or abilities with a set
icon color, it may break existing listeners that assume that they are
only receiving abilities that match those criteria.

This change keeps the old event and introduces a new
'OverrideBothAbilityIconColors' event, which ensures maximum
compatibility.

I have also fixed the issue references in the HL-Docs lines: it doesn't
support multiple issue numbers per feature at the moment.

Implemented Issue X2CommunityCore#749
Iridar pushed a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue May 24, 2021
@Onidotmoe
Implemented Issue X2CommunityCore#749
ea88cc1 
Switched back to EnableMouseAutomaticColor as setting Colors directly would get overriden by default upon mouseover

Changed the structure of X2CommunityCore#400 & X2CommunityCore#749 Completely

Added Highlander Docs

Changed Documentation from inout to in on IsObjective

Make ability icon color override backwards compatible

Since the new event for overriding ability icon colors is fired for
every ability icon, not just objective abilities or abilities with a set
icon color, it may break existing listeners that assume that they are
only receiving abilities that match those criteria.

This change keeps the old event and introduces a new
'OverrideBothAbilityIconColors' event, which ensures maximum
compatibility.

I have also fixed the issue references in the HL-Docs lines: it doesn't
support multiple issue numbers per feature at the moment.

Implemented Issue X2CommunityCore#749
Iridar pushed a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue May 24, 2021
@Onidotmoe
Implemented Issue X2CommunityCore#749
9f2a408
Iridar pushed a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue May 26, 2021
@Onidotmoe
Implemented Issue X2CommunityCore#749
498091c 
Co-authored-by: Peter Ledbrook <peter@cacoethes.co.uk>
pledbrook pushed a commit that referenced this issue May 28, 2021
@Iridar
Add improved hook for overriding ability icon colors (#749)
722afd9 
The new event `OverrideAbilityIconColorImproved` supersedes the old
`OverrideAbilityIconColor` one and provides mods with the ability to
override both the foreground and background ability icon colors. The
old event will continue to work, but if a listener overrides the
colors using the new event, that will override any listener that uses
the old event.

Resolves #749.
Iridar added a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue Jul 4, 2021
@Iridar
Issue X2CommunityCore#1031 - temporarily disable 'OverrideAbilityIcon…
bcc72b2 
…Color' (X2CommunityCore#400) and 'OverrideAbilityIconColorImproved' (X2CommunityCore#749) events to prevent a hard hang when using moving melee.
@Iridar Iridar mentioned this issue Jul 5, 2021
Closed
Iridar added a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue Jul 7, 2021
@Iridar
Revert "Issue X2CommunityCore#1031 - temporarily disable 'OverrideAbi…
088f16d 
…lityIconColor' (X2CommunityCore#400) and 'OverrideAbilityIconColorImproved' (X2CommunityCore#749) events to prevent a hard hang when using moving melee."

This reverts commit bcc72b2.
Iridar added a commit to Iridar/X2WOTCCommunityHighlander that referenced this issue Jul 9, 2021
@Iridar
Revert "Issue X2CommunityCore#1031 - temporarily disable 'OverrideAbi…
b2ab7e7 
…lityIconColor' (X2CommunityCore#400) and 'OverrideAbilityIconColorImproved' (X2CommunityCore#749) events to prevent a hard hang when using moving melee."

This reverts commit bcc72b2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add event to override ability icon color Iridar/X2WOTCCommunityHighlander
1 participant
@Onidotmoe