Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsIncapacitated check to GatherUnitsToMove #1193 #1194

Merged
merged 4 commits into from
Aug 10, 2023

Conversation

Tepa00
Copy link
Contributor

@Tepa00 Tepa00 commented Jun 11, 2023

This allows the AI to skip incapacitated units in a group which has other units able to act.

fixes #1193

@Iridar Iridar added this to the 1.26.0 milestone Jun 24, 2023
@Iridar Iridar added the ready-to-review A pull request is ready to be reviewed label Jun 24, 2023
Copy link
Contributor

@Iridar Iridar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs still mention the IsIncapacitated(), please update. Also I think this should have the

/// HL-Docs: ref:Bugfixes; issue:1193

tag.

@Tepa00 Tepa00 requested a review from Iridar June 25, 2023 14:04
Removed redundant Issue # tag.
@Iridar Iridar added ready-for-merge the pull request was reviewed and is ready to be merged. and removed ready-to-review A pull request is ready to be reviewed labels Jun 25, 2023
@Iridar
Copy link
Contributor

Iridar commented Jun 25, 2023

Approved, to be squash merged, ideally test first.

@Iridar
Copy link
Contributor

Iridar commented Aug 10, 2023

Tested, seems to be working.

@Iridar Iridar merged commit bc54627 into X2CommunityCore:master Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-basegame ready-for-merge the pull request was reviewed and is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enemy AI chokes on unconcious units
2 participants