Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Return Fire visualize after Covering Fire Overwatch #1214

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

Iridar
Copy link
Contributor

@Iridar Iridar commented Jun 29, 2023

Fixes #1196

Test before merging.

@Iridar Iridar added this to the 1.26.0 milestone Jun 29, 2023
@Iridar Iridar self-assigned this Jun 29, 2023
@Iridar Iridar added the ready-to-review A pull request is ready to be reviewed label Jun 29, 2023
@Iridar Iridar changed the title Implement Issue #1196 Make Return Fire visualize after Covering Fire Overwatch Jun 29, 2023
@Iridar
Copy link
Contributor Author

Iridar commented Aug 10, 2023

Tested by having a bunch of soldiers with Covering Fire and Return Fire overwatch camp a bunch of enemies for quite a bit of time. Worked fine, the only weird interaction was the soldier return fire on a sectoid after being panicked by mindspin.

Without this change it visualizes almost the same, so it's not strictly relevant to this issue.

@Iridar Iridar merged commit d7b1c6c into X2CommunityCore:master Aug 10, 2023
4 checks passed
@Iridar Iridar deleted the 1196-return-fire-vis-fix branch August 10, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-basegame ready-to-review A pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return Fire and Covering Fire fight for visualization
2 participants