Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GetAttackingDamageModifier_CH() that always gets the damage effect #1306

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Add GetAttackingDamageModifier_CH() that always gets the damage effect #1306

merged 1 commit into from
Mar 3, 2024

Conversation

Iridar
Copy link
Contributor

@Iridar Iridar commented Feb 27, 2024

Fixes #1305

@Iridar Iridar added enhancement ready-to-review A pull request is ready to be reviewed labels Feb 27, 2024
@Iridar Iridar added this to the 1.28.0 milestone Feb 27, 2024
@Iridar Iridar self-assigned this Feb 27, 2024
@Iridar Iridar mentioned this pull request Feb 27, 2024
Open
@Iridar Iridar added ready-for-merge the pull request was reviewed and is ready to be merged. and removed ready-to-review A pull request is ready to be reviewed labels Mar 3, 2024
@Iridar Iridar merged commit 70f9d85 into X2CommunityCore:master Mar 3, 2024
4 checks passed
@Iridar Iridar deleted the 1305-damage-effect-for-attacking-damage-modifier branch March 3, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tedster59 Tedster59 Awaiting requested review from Tedster59

Assignees

@Iridar Iridar

Labels
enhancement ready-for-merge the pull request was reviewed and is ready to be merged.
Projects
None yet
Milestone
1.28.0
Development

Successfully merging this pull request may close these issues.

X2Effect_Persistent::GetAttackingDamageModifier() does not get the damage effect during damage preview
2 participants
@Iridar @ps2guides