Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly trigger unit concealment loss when bForceNoSquadConcealment flag is set instead of not concealing in the first place. #1351

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BlackDog86
Copy link
Contributor

@BlackDog86 BlackDog86 commented May 31, 2024

Fixes #1319

This is a preliminary fix for review & likely will need some changes but just creating a PR for review / conversation.

The code adjustment fixes the problem by starting the squad in concealment and then breaking it if the dark event / battledata flag bForceNoSquadConcealment is set, instead of not setting concealment on the squad in the first place. It works properly with phantom & reaper shadow but at the moment it creates a lot of flyovers on mission start which I suspect which looks a bit messy & I suspect will prevent this from being merged directly - I haven't sorted the comments out yet either!

Basically, on missions where the squad starts concealed and high alert is active you now get the following situation:
"High Alert Flyover"
"Concealed Flyover"
"Revealed Flyover"
(Optional if you have a ranger) "Phantom Ranger Concealed Flyover"

Normal mission start flyovers are not affected.

It would be ideal if we could come up with a way to suppress the visualiser when we use the SetSquadConcealment function but I don't really know how to do that at this point. Advice welcome!

@BlackDog86 BlackDog86 self-assigned this Aug 3, 2024
@BlackDog86 BlackDog86 added the waiting-on-author A pull request is waiting on changes from the author label Aug 3, 2024
@BlackDog86 BlackDog86 added this to the 1.29.0 milestone Aug 3, 2024
@Iridar
Copy link
Contributor

Iridar commented Sep 5, 2024

Since the issue is specifically with the mission, perhaps it's the mission that needs to be fixed? Perhaps changing the mission trigger from "XCOM breaks concealment" to "XCOM unit sighted". Either that or "or mission start if XCOM starts unconcealed". The latter is less friendly towards the player, but makes more sense with the mission narrative that goes "ADVENT already knows we're here".

The problem of course is mission logic is probably in kismet, and I'm not sure if we can fix it in CHL.

…data flag which forces concealment off. Still need to adjust things in respect of visualisation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-on-author A pull request is waiting on changes from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ADVENT does not extract supplies from the Extract Supplies mission if XCOM starts unconcealed
2 participants