-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs - Gremlin customization #1367
Add docs - Gremlin customization #1367
Conversation
UseAppearance = OwningUnit.kAppearance; | ||
UseAppearance.iArmorTint = UseAppearance.iWeaponTint; | ||
UseAppearance.iArmorTintSecondary = UseAppearance.iArmorTintSecondary; | ||
UseAppearance.nmPatterns = UseAppearance.nmWeaponPattern; | ||
// End Issue #380 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no reason to remove these two issue tags.
271899c
to
f4dcb30
Compare
I'm sorry, but this still seems to remove Start Issue / End Issue tags in XComUnitPawn, what's up with that? |
I explained this in the comment above - The original file had this:
I simply changed to
|
I see. The purpose of ref:Bugfixes docs is to be user-facing. As in, it should be treated as an entry in a changelog that explains the bug that is being fixed to Highlander users. If it's just a comment that explains to Highlander maintainers and Highlander-using mod authors, it doesn't need a docs entry. Something like "Moved earlier so we can call SetAppearance() whether a new pawn is created or not" doesn't really explain what is being fixed here, so if you could reword it a bit, it would be appreciated. |
4b02ba5
to
289fd40
Compare
Yep, I see what you mean. That should be done now. |
Adds docs for Issue #380