Allow forcing 24h clock and leading zeroes on month and date strings

[BlackDog86]

Fixes #1400

[Iridar]

This seems like an opinionated change, it should be at least gated behind a separate config var.

[BlackDog86]

this isn't really a change at all - the default localization file uses this for the display of dates:
m_strMonthDayYearShort="<XGParam:IntValue2/><XGParam:StrValue1/!SeparatorString/><XGParam:IntValue0/><XGParam:StrValue1/!SeparatorString/><XGParam:IntValue1/>"

The default display would therefore not change at all with the code adjustment. A mod would have to specifically remove the original localization line and replace it with XGParam:StrValue2 or XGParam:StrValue3 explicitly in order for this to adjust base-game behaviour at all so I don't think a config gate is necessary.

[Iridar]

Does this have to be a Highlander change then? It this does nothing without mod-supplied localization lines, what's stopping the mod that is adding those lines from adding its own localized tags and using the tag expand handler to fill them with whatever date format it wants?

[BlackDog86]

Because the mod would need to MCO X2StrategyGameRulesetDataStrcutures just to create a couple of tags which is quite an invasive MCO for a very small change (plus there are already some mods existing MCOing other parts of this, creating conflicts. I thought this sort of thing is more or less exactly what CHL is for?)

[Iridar]

I don't understand why would MCO be necessary. You can create arbitrary tags and fill them with arbitrary content via the DLC Hook, no MCO required. Mods can always ship their own adjusted version of GetTimeStringSeparated() to use in their tags.

[BlackDog86]

After a bit of further investigation & for the purposes of clarity, the only place that the 'short' date is actually called for in the base game, is in the memorial screen. However, other mods (such as beat's mission history) also call for it. See below some examples of the display options:
Memorial before:

Memorial after, swapping the short date tags in localization:

Clock example, base game:

Clock example with bforce24hclock and bforce24hclockleadingzero on:

Clock example with bforce24hclock and bforce24hclockleadingzero on and using tag swapping to swap the long dates as well (doing this can adjust the format for soldier birthdays, research reports, avenger facility construction dates in 'avenger report' and a couple other places.

I should say that the save and load game screens do not use this function and have their own logic for parsing the save file headers to display the dates of the save games. This logic isn't great either in my view and in one of my own mods I MCO a few of the classes responsible in order to display those dates differently (https://steamcommunity.com/sharedfiles/filedetails/?id=3268722967). This is the output of that mod, for example:
. The base-game code is a bit janky in that area as well but making that better is out of scope for this, which is just making a few small changes for the sake of flexibility.

[Iridar]

For context to the above discussion, I didn't understand that the following pipeline was in place:

1. Different parts of the code call the GetDateString() function
2. Which takes one of the two existing strings that exist solely for the purpose of arranging date
3. Expands its tags
4. Returns the formatted date to whatever code caled the function

So I didn't understand why changes to GetDateString() were necessary.