Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the user name from required to optional parameter #650

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Changing the user name from required to optional parameter #650

merged 1 commit into from
Jun 11, 2024

Conversation

Kapple14
Copy link
Contributor

Changing the user name parameter from required to optional following the official API guidelines. See https://docs.github.com/en/rest/users/users?apiVersion=2022-11-28 for more

Changing the user name parameter from required to optional following the official API guidelines. See https://docs.github.com/en/rest/users/users?apiVersion=2022-11-28 for more
Copy link
Contributor

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Kapple14
Copy link
Contributor Author

Thanks for the fast approval.

@Kapple14 Kapple14 closed this Jun 11, 2024
@XAMPPRocky
Copy link
Owner

XAMPPRocky commented Jun 11, 2024

I can't merge if it's closed 😄

@XAMPPRocky XAMPPRocky reopened this Jun 11, 2024
@XAMPPRocky
Copy link
Owner

Thank you for your PR, and congrats on your first contribution! 🎉

@XAMPPRocky XAMPPRocky merged commit 07557f5 into XAMPPRocky:main Jun 11, 2024
22 checks passed
This was referenced Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants